π¨ Palette: [UX improvement] Add missing focus states to calendar buttons#920
Conversation
This commit adds `focus-visible` styling (`focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring/40`) to the "μμ " button in `CalendarSidebarRight` and the "μ μΌμ intent μ κ²" button in `CalendarWritebackSection`. This provides a visual indicator to keyboard users, enhancing keyboard navigation accessibility.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit adds `focus-visible` styling (`focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring/40`) to the "μμ " button in `CalendarSidebarRight` and the "μ μΌμ intent μ κ²" button in `CalendarWritebackSection`. This provides a visual indicator to keyboard users, enhancing keyboard navigation accessibility.
OpenCode Review Overview
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Frontend (2 files)"]
S1 --> I1["browser runtime and bundle"]
I1 --> R1["Review risk: Frontend (2 files)"]
R1 --> V1["frontend tests"]
|
π‘ What: Added missing
focus-visiblestyles to calendar action buttons (CalendarSidebarRightandCalendarWritebackSection).π― Why: Improves keyboard accessibility by providing a clear visual indicator when the button is focused.
πΈ Before/After: Interactive buttons previously lacked a focus ring; now they have a clear outline when focused via keyboard navigation.
βΏ Accessibility: Ensures keyboard users can easily see which element has focus.
PR created automatically by Jules for task 2665236050190142270 started by @seonghobae