chore(ci): delegate PR CodeQL to org central codeql-pr.yml#916
chore(ci): delegate PR CodeQL to org central codeql-pr.yml#916seonghobae wants to merge 1 commit into
Conversation
Keep repository codeql.yml for default-branch push scans only. PR merge gates now rely on ContextualWisdomLab/.github codeql-pr.yml via org ruleset 18156473, matching osv-scanner-pr and scorecard-pr posture.
OpenCode Review Overview
Pull request overviewOpenCode reviewed the current-head bounded evidence and found no blocking issues. FindingsNo blocking findings. SummaryApproval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: codeql.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: codeql.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Backend: test_release_governance.py"]
S2 --> I2["API and service runtime"]
I2 --> R2["Review risk: Backend: test_release_governance.py"]
R2 --> V2["backend tests"]
|
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head bounded evidence and found no blocking issues.
Findings
No blocking findings.
Summary
Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .github/workflows/codeql.yml, backend/tests/test_release_governance.py.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects .github/workflows/codeql.yml to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.
- Result: APPROVE
- Reason: CI simplification with central CodeQL delegation
- Head SHA:
58f8f6ece398b5616c26c971524c94d91d25c92b - Workflow run: 28712143358
- Workflow attempt: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: codeql.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: codeql.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Backend: test_release_governance.py"]
S2 --> I2["API and service runtime"]
I2 --> R2["Review risk: Backend: test_release_governance.py"]
R2 --> V2["backend tests"]
Summary
codeql.ymlto default-branch push scans only (develop/master).18156473centralContextualWisdomLab/.githubworkflowcodeql-pr.ymlfor PR-head and merge-preview CodeQL SARIF (same posture asosv-scanner-pr.ymlandscorecard-pr.yml).Depends on
main18156473adding.github/workflows/codeql-pr.ymlas a required workflowTest plan
pytest backend/tests/test_release_governance.py::test_codeql_workflow_uploads_default_branch_sarif_onlypytest backend/tests/test_release_governance.py::test_central_required_workflows_include_codeql_pr_for_ruleset_gatepytest backend/tests/test_release_governance.py::test_review_automation_uses_central_required_workflows_without_local_copies