Expose card titles as accessible headings#890
Open
seonghobae wants to merge 1 commit into
Open
Conversation
Contributor
|
PR governance metadata gate is not ready for
|
There was a problem hiding this comment.
Pull request overview
This PR improves frontend accessibility by rendering shared card titles as semantic headings, and updates AI Hub Playwright E2E selectors/text to match the current tab semantics and “판단 보조” terminology.
Changes:
- Render
CardTitleas anh3so titled cards are exposed to assistive tech as headings. - Update AI Hub E2E navigation to use
tab/tabpanelroles (instead of generic buttons/regions). - Align AI Hub surface label text from “AI 에이전트” to “판단 보조”.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/components/ui/card.tsx | Switches CardTitle from <div> to <h3> to provide semantic headings for card titles. |
| frontend/tests/e2e/ai-hub-source-surface.spec.ts | Updates Playwright selectors to target tab/tabpanel roles and the renamed “판단 보조” tab. |
| frontend/tests/e2e/helpers.ts | Updates AI Hub surface fixture/expected label text to “판단 보조”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes