Skip to content

Expose card titles as accessible headings#890

Open
seonghobae wants to merge 1 commit into
developfrom
codex/7th-pass-audit
Open

Expose card titles as accessible headings#890
seonghobae wants to merge 1 commit into
developfrom
codex/7th-pass-audit

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • render shared CardTitle as an h3 so visually titled cards are exposed as headings
  • align AI Hub e2e selectors with tab/tabpanel roles and current 판단 보조 terminology

Verification

  • pnpm exec eslint
  • pnpm exec tsc --noEmit
  • pnpm exec vitest run --reporter=dot --maxWorkers=1
  • pnpm exec playwright test tests/e2e/ai-hub-source-surface.spec.ts

Notes

  • Figma live metadata remains blocked by HTTP 401 token_invalidated, so this patch is based on repository UI evidence and Playwright screenshots/role checks.

Copilot AI review requested due to automatic review settings July 1, 2026 07:12
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for 79b39298c219db3ceccca315a7e9aa2698fe2545:

  • Required check metadata could not be read: no required checks reported on the 'codex/7th-pass-audit' branch.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves frontend accessibility by rendering shared card titles as semantic headings, and updates AI Hub Playwright E2E selectors/text to match the current tab semantics and “판단 보조” terminology.

Changes:

  • Render CardTitle as an h3 so titled cards are exposed to assistive tech as headings.
  • Update AI Hub E2E navigation to use tab/tabpanel roles (instead of generic buttons/regions).
  • Align AI Hub surface label text from “AI 에이전트” to “판단 보조”.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
frontend/src/components/ui/card.tsx Switches CardTitle from <div> to <h3> to provide semantic headings for card titles.
frontend/tests/e2e/ai-hub-source-surface.spec.ts Updates Playwright selectors to target tab/tabpanel roles and the renamed “판단 보조” tab.
frontend/tests/e2e/helpers.ts Updates AI Hub surface fixture/expected label text to “판단 보조”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants