🎨 Palette: CLI 시뮬레이션 명령의 에러 처리 개선 (DX 향상)

[seonghobae]

💡 What: fast-mlsirm simulate CLI 명령 수행 중 발생하는 설정 관련 ValueError를 캐치하여 깔끔한 에러 메시지로 반환하도록 개선했습니다.
🎯 Why: 기존에는 유효하지 않은 인자(예: --persons -5)를 넣었을 때 원시적인 Python Stack Trace가 노출되어 사용자(개발자) 경험이 떨어졌습니다. try-except 처리를 통해 다른 명령어들(fit, diagnose-fit 등)과 동일하게 일관된 에러 처리 및 상태 코드를 반환하도록 개선했습니다.
📸 Before/After:
Before:

⏳ Simulating -5 persons and 2 dimensions...
Traceback (most recent call last):
  ...
ValueError: n_persons must be >= 1

After:

⏳ Simulating -5 persons and 2 dimensions...
❌ Error: Invalid configuration - n_persons must be >= 1

---

PR created automatically by Jules for task 11773325611873390064 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[Copilot]

Pull request overview

fast-mlsirm simulate 실행 중 잘못된 설정값으로 인해 발생하는 ValueError를 CLI 레벨에서 캐치해, Python 스택트레이스 대신 일관된 사용자 친화적 에러 메시지와 종료 코드(1)를 반환하도록 개선합니다.

Changes:

• simulate 서브커맨드에서 simulate(MLS2PLMConfig(...)) 호출을 try/except ValueError로 감쌈
• 설정 오류 시 stderr로 ❌ Error: Invalid configuration - ... 출력 후 return 1 처리

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval

• Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
• Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
• Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
• Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.

Review thread evidence

Latest unresolved reviewer thread evidence

python/fast_mlsirm/cli.py line 201

• Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-02T02:55:09Z

• Comment URL: #60 (comment)

• Comment excerpt: The new 'simulate' ValueError handling path isn’t covered by tests, so regressions (e.g., returning a traceback again or changing the exit code/message) would go unnoticed. Add a CLI test that runs 'main()' with an invalid '--persons' (or other invalid config) and asserts exit code 1 and that stderr contains the expected "Invalid configuration" message.

• Result: REQUEST_CHANGES

• Reason: unresolved reviewer or review-agent thread(s) were present before approval.

• Head SHA: 20413b1e44823587057a22ed3ff2684078cb23f7

• Workflow run: 28562002543

• Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: cli.py"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: cli.py"]
  R1 --> V1["required checks"]

Loading

[github-actions]

OpenCode Review Overview

• Head SHA: 20413b1e44823587057a22ed3ff2684078cb23f7
• Workflow run: 28562002543
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval

• Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
• Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
• Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
• Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.

Review thread evidence

Latest unresolved reviewer thread evidence

python/fast_mlsirm/cli.py line 201

• Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-02T02:55:09Z

• Comment URL: 🎨 Palette: CLI 시뮬레이션 명령의 에러 처리 개선 (DX 향상) #60 (comment)

• Comment excerpt: The new 'simulate' ValueError handling path isn’t covered by tests, so regressions (e.g., returning a traceback again or changing the exit code/message) would go unnoticed. Add a CLI test that runs 'main()' with an invalid '--persons' (or other invalid config) and asserts exit code 1 and that stderr contains the expected "Invalid configuration" message.

• Result: REQUEST_CHANGES

• Reason: unresolved reviewer or review-agent thread(s) were present before approval.

• Head SHA: 20413b1e44823587057a22ed3ff2684078cb23f7

• Workflow run: 28562002543

• Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: cli.py"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: cli.py"]
  R1 --> V1["required checks"]

Loading