Skip to content

🎨 Palette: 슀크둀 κ°€λŠ₯ν•œ ν…Œμ΄λΈ” μ ‘κ·Όμ„± κ°œμ„ #54

Open
seonghobae wants to merge 1 commit into
mainfrom
palette/accessible-tables-16494223473979403972
Open

🎨 Palette: 슀크둀 κ°€λŠ₯ν•œ ν…Œμ΄λΈ” μ ‘κ·Όμ„± κ°œμ„ #54
seonghobae wants to merge 1 commit into
mainfrom
palette/accessible-tables-16494223473979403972

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ μž‘μ—… λ‚΄μš© (What):
μƒμ„±λœ HTML λ³΄κ³ μ„œμ˜ ν…Œμ΄λΈ”μ„ κ°μ‹ΈλŠ” .table-wrap μš”μ†Œμ— tabindex="0", role="region", aria-label 속성을 μΆ”κ°€ν•˜κ³ , ν‚€λ³΄λ“œλ‘œ μš”μ†Œμ— μ ‘κ·Ό μ‹œ 포컀슀 링이 보이도둝 :focus-visible CSSλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. λ˜ν•œ, 이 λ°œκ²¬μ„ λ°”νƒ•μœΌλ‘œ μ ‘κ·Όμ„± ν•™μŠ΅ 일지(.jules/palette.md)λ₯Ό μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 이유 (Why):
overflow-x: autoκ°€ 적용된 슀크둀 κ°€λŠ₯ν•œ μ»¨ν…Œμ΄λ„ˆλŠ” ν‚€λ³΄λ“œλ§Œ μ‚¬μš©ν•˜λŠ” μ‚¬μš©μž(예: μ‹œκ° μž₯애인 λ˜λŠ” 마우슀 μ‚¬μš©μ΄ λΆˆνŽΈν•œ μ‚¬μš©μž)κ°€ ν™”λ©΄ λ°–μ˜ μ½˜ν…μΈ λ₯Ό μŠ€ν¬λ‘€ν•˜μ—¬ λ³Ό 수 μ—†κ²Œ λ§Œλ“­λ‹ˆλ‹€. 이λ₯Ό ν•΄κ²°ν•˜κΈ° μœ„ν•΄ 포컀슀λ₯Ό 받을 수 있게 ν•˜κ³  슀크린 리더가 μ»¨ν…μŠ€νŠΈλ₯Ό 이해할 수 μžˆλ„λ‘ 의미적 νƒœκ·Έμ™€ 라벨을 λΆ€μ—¬ν•΄μ•Ό ν•©λ‹ˆλ‹€.

β™Ώ μ ‘κ·Όμ„± κ°œμ„  사항 (Accessibility):

  • 슀크둀 κ°€λŠ₯ν•œ ν…Œμ΄λΈ”μ˜ ν‚€λ³΄λ“œ λ„€λΉ„κ²Œμ΄μ…˜ 지원
  • 슀크린 λ¦¬λ”μš© μ§€μ—­ 뢄리(role="region") 및 μ„€λͺ…(aria-label) μΆ”κ°€
  • λͺ…ν™•ν•œ μ‹œκ°μ  포컀슀 μƒνƒœ(Outline) 제곡

PR created automatically by Jules for task 16494223473979403972 started by @seonghobae

- `.table-wrap`에 `tabindex="0"`, `role="region"`, `aria-label` 속성 μΆ”κ°€
- `.table-wrap:focus-visible` CSS κ·œμΉ™μ„ μΆ”κ°€ν•˜μ—¬ ν‚€λ³΄λ“œ 포컀슀 μ‹œ μ‹œκ°μ  ν”Όλ“œλ°± 제곡
- κ΄€λ ¨ μ ‘κ·Όμ„± ν•™μŠ΅ λ‚΄μš©μ„ `.jules/palette.md`에 기둝
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 1, 2026 18:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves accessibility of generated HTML report tables by making horizontally scrollable table containers keyboard-focusable, semantically identifiable to assistive tech, and visibly focused when navigated via keyboard.

Changes:

  • Pass the section heading into _table() so the wrapper can expose a descriptive accessible name.
  • Add tabindex="0", role="region", and aria-label to the .table-wrap scroll container.
  • Add a .table-wrap:focus-visible outline style (plus accompanying accessibility learning notes in .jules/palette.md).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
python/fast_mlsirm/report.py Makes scrollable table wrappers focusable and labeled for screen readers; adds focus outline styling.
.jules/palette.md Documents the accessibility learning and the chosen implementation pattern.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +572 to +575
.table-wrap:focus-visible {
outline: 2px solid var(--teal);
outline-offset: 1px;
}

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval

  • Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
  • Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
  • Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
  • Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.

Review thread evidence

Latest unresolved reviewer thread evidence

python/fast_mlsirm/report.py line 575

  • Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T18:56:06Z

  • Comment URL: #54 (comment)

  • Comment excerpt: ':focus-visible' is great, but in browsers/environments that don't support it the focus outline won't show at all. Adding a ':focus' fallback (gated with '@supports selector(:focus-visible)') keeps the current behavior where supported while preserving a visible focus indicator elsewhere.

  • Result: REQUEST_CHANGES

  • Reason: unresolved reviewer or review-agent thread(s) were present before approval.

  • Head SHA: 9636ebadd2b1fde1e6f156dbb3daeb5df04335a5

  • Workflow run: 28540520832

  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
Loading

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

OpenCode Review Overview

  • Head SHA: 9636ebadd2b1fde1e6f156dbb3daeb5df04335a5
  • Workflow run: 28540520832
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval

  • Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
  • Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
  • Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
  • Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.

Review thread evidence

Latest unresolved reviewer thread evidence

python/fast_mlsirm/report.py line 575

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants