Skip to content

Install Rust quality tools for pinned toolchain - #1272

Closed
seonghobae wants to merge 1 commit into
mainfrom
fix/rust-gate-pinned-components
Closed

seonghobae wants to merge 1 commit into
mainfrom
fix/rust-gate-pinned-components

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Gap

The Security workflow installs rustfmt and clippy on stable, then the repository's rust-toolchain.toml selects pinned 1.97.1 for cargo fmt. The pinned toolchain lacks rustfmt, causing the Rust workspace gate to fail before any code checks run. This is reproduced in #1220's prior-head job 108109544836 and on other PRs.

Change

Install the components for the active pinned toolchain using rustup component add. Remove the ineffective rustup default stable override.

Verification

  • actionlint .github/workflows/security.yml
  • ../.venv/bin/python -m pytest -q tests/test_repository_security_metadata.py (14 passed)
  • git diff --check

The hosted Rust job is the final validation boundary.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 088150a6-375c-48ac-a84d-92835d8933bb

📥 Commits

Reviewing files that changed from the base of the PR and between 5665b0a and 8922760.

📒 Files selected for processing (1)
  • .github/workflows/security.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T11:12:30.195135Z 8922760 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seonghobae
seonghobae enabled auto-merge (squash) September 26, 2026 11:10
@seonghobae seonghobae closed this Sep 26, 2026
auto-merge was automatically disabled September 26, 2026 11:22

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant