Repository navigation
Install Rust quality tools for pinned toolchain - #1272
seonghobae wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pull request was closed
Gap
The Security workflow installs
rustfmtandclippyonstable, then the repository'srust-toolchain.tomlselects pinned1.97.1forcargo fmt. The pinned toolchain lacksrustfmt, causing the Rust workspace gate to fail before any code checks run. This is reproduced in #1220's prior-head job 108109544836 and on other PRs.Change
Install the components for the active pinned toolchain using
rustup component add. Remove the ineffectiverustup default stableoverride.Verification
actionlint .github/workflows/security.yml../.venv/bin/python -m pytest -q tests/test_repository_security_metadata.py(14 passed)git diff --checkThe hosted Rust job is the final validation boundary.