Repository navigation
test(route): account for default retry in contract receipts - #1210
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Independent agent review (comment only; this is not an APPROVED review and does not satisfy the nonauthor approval gate).
Verdict on the actual stacked diff f9d0731211e84360ce7e0b5fde08bfaf3ef1d23b..26b71dbbef11f1779a83495b0b2096a6bd7e2c3d: no actionable diff-local findings. The changed assertions correctly pin the real three transport calls (primary, retry primary, then fallback) and keep the nested judge call outside the worker route receipt.
Bounded verification with the existing installed interpreter: python -m pytest -q tests/test_api_contract.py::test_orchestration_route_schema_validates_route_once_failover tests/test_api_contract.py::test_route_once_preserves_worker_failover_evidence_across_realtime_judge -> exit 0, 2 passed. I did not run the full suite or rebuild native components. The stack base itself has a separately reported Ruff F821 blocker in _invoke_with_rate_limit_recovery; it predates this PR diff, so this no-findings verdict is diff-local rather than a clean-head claim.
…ck-drift repair The restack merge 3078949 (landed on main through #1074) dropped the request execution scope, effort/policy snapshots and selection_design receipts while keeping their tests. The open stack #1205 -> #1208 -> #1210 -> #1211 -> #1212 -> #1213 restores them; merging its head fea207f greens 62 of the 72 latent protected-main failures (request_effort_snapshot, request_policy_snapshot, distributed cache, endpoint_race, true_streaming, provider_reliability, 7 psychometric). Approved by the coordinator; the trial tree d5096e4 was reproduced independently by the CO lead. No conflicts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeLbwEgYXzCzpaFMTHDcBS
|
Admission correction — exact current head |
26b71db
into
seonghobae/fix-1016-route-once-typed-attempts
Two route_once contract tests omitted the default same-candidate retry from their expected receipts and therefore failed despite correctly recorded attempts. Count actual client calls and require both failed primary attempts before fallback; the nested-judge case also proves the later judge call does not enter worker route evidence. Production retry policy is unchanged.
Stacked follow-up to #1208 so its head and queued checks remain intact.
Validation: isolated source environment,
python -m pytest -q -W error tests/test_api_contract.py: 12 passed, exit 0. Prior #1208 baseline logs record both assertions failing. This is transport-double evidence, not wire delivery or hosted CI acceptance. Other previously recorded HTTP resource failures remain outside this change.