Skip to content

🛡️ Sentinel: [CRITICAL] Add authentication to admin endpoints - #689

Open
seonghobae wants to merge 4 commits into
mainfrom
secure-admin-endpoints-10957112415319783612
Open

seonghobae wants to merge 4 commits into
mainfrom
secure-admin-endpoints-10957112415319783612

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

🛡️ Sentinel: [CRITICAL] Add authentication to admin endpoints

Severity: CRITICAL
Vulnerability: The admin endpoints (/api/v1/admin/convert/jobs, etc) lacked tenant access enforcement, allowing unauthorized cross-tenant job access.
Impact: Any unauthenticated or cross-tenant attacker could retrieve, delete, or manipulate the status of conversion jobs belonging to other tenants.
Fix: Injected TenantAccessService and strictly required the admin:operate permission on all administrative handlers.
Verification: Ran mvn verify and checked that Checkstyle / test coverage passed successfully. Added journal learning to .jules/sentinel.md.


PR created automatically by Jules for task 10957112415319783612 started by @seonghobae

Summary by CodeRabbit

  • 보안
    • 관리자 작업 목록 조회, 삭제 및 재시도 요청에 admin:operate 권한 확인이 적용됩니다. 권한이 없는 요청은 해당 작업을 수행할 수 없습니다.
    • 작업 조회·변경 기능은 요청 헤더의 인증 정보를 바탕으로 권한을 확인합니다. 기존 작업 목록 필터링, 삭제 응답 및 재시도 결과 처리는 유지됩니다.

Severity: CRITICAL
Vulnerability: The admin endpoints (`/api/v1/admin/convert/jobs`, etc) lacked tenant access enforcement, allowing unauthorized cross-tenant job access.
Impact: Any unauthenticated or cross-tenant attacker could retrieve, delete, or manipulate the status of conversion jobs belonging to other tenants.
Fix: Injected `TenantAccessService` and strictly required the `admin:operate` permission on all administrative handlers.
Verification: Ran `mvn verify` and checked that Checkstyle / test coverage passed successfully. Added journal learning to `.jules/sentinel.md`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6e2d534a-58fb-4224-804a-a489617de149
📥 Commits

Reviewing files that changed from the base of the PR and between 06633a2 and a39a1d4.

📒 Files selected for processing (4)
  • .jules/sentinel.md
  • src/main/java/com/clearfolio/viewer/auth/TenantPermissions.java
  • src/main/java/com/clearfolio/viewer/controller/AdminController.java
  • src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant