Skip to content

⚡ Bolt: 원시 타입 박싱 방지 및 StringBuilder를 활용한 Ledger 직렬화 최적화 #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: 원시 타입 박싱 방지 및 StringBuilder를 활용한 Ledger 직렬화 최적화 #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@
## 2026-07-13 - 단일 패스 문자열 치환 최적화 (O(N) 단일 스캔 및 지연 할당)
**Learning:** `String.replace()`를 여러 번 체이닝하여 호출하면, 문자열 치환이 발생하지 않는 경우에도 내부적으로 불필요한 스캔이 중복 발생하고, 치환 시마다 새로운 문자열 객체와 char 배열이 할당되어 메모리 낭비와 성능 저하(GC 압박)가 발생한다.
**Action:** 여러 문자를 한 번에 치환해야 하는 경우, O(N) 단일 스캔을 통해 `charAt()`으로 문자를 확인하고, 치환이 실제로 필요한 경우에만 `StringBuilder`를 지연 할당(Lazy allocation)하여 성능을 최적화하고 불필요한 메모리 할당을 방지한다.
## 2026-10-05 - Optimize ledger serialization with StringBuilder
**Learning:** Using `String.join("\t", ...)` for structuring ledgers with many fields (e.g., `ArtifactLinkLedger`, `KpiSnapshotLedger`) creates unnecessary string allocations and vararg array overhead.
**Action:** Use pre-sized `StringBuilder` and chained `.append()` to avoid string array allocations. Pass primitive types directly to `.append()` rather than wrapping in `String.valueOf()` to reduce temporary object allocations.
30 changes: 16 additions & 14 deletions src/main/java/com/clearfolio/viewer/analytics/KpiSnapshotLedger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,20 +148,22 @@ private void appendLine(String line) {
}

private static String serialize(KpiSnapshotRecord record) {
return String.join("\t",
SNAPSHOT,
field(record.tenantId()),
field(record.subjectId()),
field(record.exportedAt()),
String.valueOf(record.totalJobs()),
String.valueOf(record.submittedJobs()),
String.valueOf(record.processingJobs()),
String.valueOf(record.succeededJobs()),
String.valueOf(record.failedJobs()),
String.valueOf(record.deadLetteredJobs()),
String.valueOf(record.conversionSuccessRate()),
field(record.p95TimeToPreviewMs())
);
// Optimization: Use pre-sized StringBuilder with chained appends to avoid
// varargs array creation and String.valueOf() allocations in String.join()
return new StringBuilder(256)
.append(SNAPSHOT).append("\t")
.append(field(record.tenantId())).append("\t")
.append(field(record.subjectId())).append("\t")
.append(field(record.exportedAt())).append("\t")
.append(record.totalJobs()).append("\t")
.append(record.submittedJobs()).append("\t")
.append(record.processingJobs()).append("\t")
.append(record.succeededJobs()).append("\t")
.append(record.failedJobs()).append("\t")
.append(record.deadLetteredJobs()).append("\t")
.append(record.conversionSuccessRate()).append("\t")
.append(field(record.p95TimeToPreviewMs()))
.toString();
}

private static String field(String value) {
Expand Down
70 changes: 36 additions & 34 deletions src/main/java/com/clearfolio/viewer/artifact/ArtifactLinkLedger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,46 +232,48 @@ private void appendLine(String line) {
}

private static String serializeIssued(ArtifactLinkRecord record) {
return String.join("\t",
ISSUED,
field(record.tokenId()),
field(record.tenantId()),
field(record.subjectId()),
record.docId().toString(),
field(record.scope()),
field(record.purpose()),
field(record.artifactChecksum()),
field(record.viewerSessionId()),
field(record.issuedAt()),
field(record.expiresAt()),
field(record.revokedAt()),
field(record.revokedBy()),
field(record.revokeReason())
);
// Optimization: Use pre-sized StringBuilder with chained appends to avoid
// varargs array creation and String.valueOf() allocations in String.join()
return new StringBuilder(256)
.append(ISSUED).append("\t")
.append(field(record.tokenId())).append("\t")
.append(field(record.tenantId())).append("\t")
.append(field(record.subjectId())).append("\t")
.append(record.docId().toString()).append("\t")
.append(field(record.scope())).append("\t")
.append(field(record.purpose())).append("\t")
.append(field(record.artifactChecksum())).append("\t")
.append(field(record.viewerSessionId())).append("\t")
.append(field(record.issuedAt())).append("\t")
.append(field(record.expiresAt())).append("\t")
.append(field(record.revokedAt())).append("\t")
.append(field(record.revokedBy())).append("\t")
.append(field(record.revokeReason()))
.toString();
}

private static String serializeRevoked(ArtifactLinkRecord record) {
return String.join("\t",
REVOKED,
field(record.tokenId()),
field(record.revokedAt()),
field(record.revokedBy()),
field(record.revokeReason())
);
return new StringBuilder(128)
.append(REVOKED).append("\t")
.append(field(record.tokenId())).append("\t")
.append(field(record.revokedAt())).append("\t")
.append(field(record.revokedBy())).append("\t")
.append(field(record.revokeReason()))
.toString();
}

private static String serializeRead(ArtifactReadEvent event) {
return String.join("\t",
READ,
field(event.tenantId()),
field(event.subjectId()),
event.docId().toString(),
field(event.tokenId()),
field(event.rangeRequested()),
String.valueOf(event.statusCode()),
field(event.traceId()),
field(event.readAt())
);
return new StringBuilder(256)
.append(READ).append("\t")
.append(field(event.tenantId())).append("\t")
.append(field(event.subjectId())).append("\t")
.append(event.docId().toString()).append("\t")
.append(field(event.tokenId())).append("\t")
.append(field(event.rangeRequested())).append("\t")
.append(event.statusCode()).append("\t")
.append(field(event.traceId())).append("\t")
.append(field(event.readAt()))
.toString();
}

private static String field(String value) {
Expand Down
Loading