ci: macOS DMG 번들링 재시도 경로 추가#543
Open
seonghobae wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
macOS DMG 번들링 단계에서 일시적인 실패(부분 DMG/마운트 잔존 등)를 자동으로 정리하고 1회 재시도할 수 있도록 CI 빌드 경로를 개선하는 PR입니다.
Changes:
tauri build를 감싸는 재시도 스크립트 추가 (환경변수로 시도 횟수 제어)- DMG 번들링 실패 시 부분 산출물 및
/Volumes/BandScope*마운트 정리 후 재시도 - GitHub Actions macOS (amd64/arm64) 빌드 단계에서 새 스크립트 사용 및 시도 횟수 2로 설정
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/release/build_tauri_bundle_with_retry.sh | tauri build 재시도 래퍼 및 DMG 상태 정리 로직 추가 |
| .github/workflows/build-baseline.yml | macOS DMG 빌드에서 재시도 스크립트를 사용하도록 CI 단계 변경 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: npm exec --workspace @bandscope/desktop -- tauri build --target "$BANDSCOPE_TARGET_TRIPLE" --bundles dmg | ||
| env: | ||
| BANDSCOPE_TAURI_BUILD_ATTEMPTS: "2" | ||
| run: scripts/release/build_tauri_bundle_with_retry.sh @bandscope/desktop "$BANDSCOPE_TARGET_TRIPLE" dmg |
| run: npm exec --workspace @bandscope/desktop -- tauri build --target "$BANDSCOPE_TARGET_TRIPLE" --bundles dmg | ||
| env: | ||
| BANDSCOPE_TAURI_BUILD_ATTEMPTS: "2" | ||
| run: scripts/release/build_tauri_bundle_with_retry.sh @bandscope/desktop "$BANDSCOPE_TARGET_TRIPLE" dmg |
Comment on lines
+23
to
+27
| if command -v hdiutil >/dev/null 2>&1; then | ||
| hdiutil info || true | ||
| hdiutil detach "/Volumes/BandScope" -force || true | ||
| hdiutil detach "/Volumes/BandScope 0.1.3" -force || true | ||
| fi |
Comment on lines
+19
to
+21
| cleanup_macos_dmg_state() { | ||
| local dmg_dir="apps/desktop/src-tauri/target/${target_triple}/release/bundle/dmg" | ||
| rm -rf "$dmg_dir" |
Comment on lines
+32
to
+38
| if npm exec --workspace "$workspace" -- tauri build --target "$target_triple" --bundles "$bundles"; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| status="$?" | ||
| if [ "$attempt" -eq "$attempts" ]; then | ||
| exit "$status" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
bundle_dmg.sh이후 부분 DMG 상태와/Volumes/BandScope*마운트를 정리한 뒤 한 번 더 빌드합니다.검증
bash -n scripts/release/build_tauri_bundle_with_retry.shpython3 scripts/checks/verify_supply_chain.pygit diff --checkReview process와 queued GitHub checks는 blocker가 아닙니다. 완료된 package failure가 재현되면 이 PR의 로그를 기준으로 후속 수정합니다.
Figma Code Connect는 사용하지 않았습니다.