Skip to content

๐ŸŽจ Palette: [UX improvement] ๋ฒ„ํŠผ ๋ž˜ํผ ARIA ์†์„ฑ ๋ฐ ์•„์ด์ฝ˜ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #540

Closed
seonghobae wants to merge 5 commits into
developfrom
palette/aria-roles-and-hidden-icons-4066132854642119452
Closed

๐ŸŽจ Palette: [UX improvement] ๋ฒ„ํŠผ ๋ž˜ํผ ARIA ์†์„ฑ ๋ฐ ์•„์ด์ฝ˜ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #540
seonghobae wants to merge 5 commits into
developfrom
palette/aria-roles-and-hidden-icons-4066132854642119452

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What:

  • App.tsx์™€ Workspace.tsx์—์„œ <button> ํƒœ๊ทธ๋ฅผ ๊ฐ์‹ธ๋Š” ํˆดํŒ์šฉ <span> ๋ž˜ํผ ํƒœ๊ทธ์— ์ž˜๋ชป ์„ ์–ธ๋œ role="button"๊ณผ aria-disabled="true"๋ฅผ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Workspace.tsx, RoleSwitcher.tsx, SectionRoadmap.tsx์—์„œ ํ…์ŠคํŠธ์™€ ํ•จ๊ป˜ ์‚ฌ์šฉ๋˜๋Š” ์‹œ๊ฐ์  ์žฅ์‹์šฉ Lucide ์•„์ด์ฝ˜๋“ค์— aria-hidden="true" ์†์„ฑ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ ‘๊ทผ์„ฑ ์ˆ˜์ • ์‚ฌํ•ญ์— ๋งž์ถฐ App.test.tsx์˜ ํ…Œ์ŠคํŠธ ๋‹จ์–ธ(assert)์„ ์—…๋ฐ์ดํŠธํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why:

  • ARIA ๋ช…์„ธ์— ๋”ฐ๋ฅด๋ฉด ๋Œ€ํ™”ํ˜• ์—ญํ• (Interactive roles, ์˜ˆ: button)์€ ๋‚ด๋ถ€์— ๋‹ค๋ฅธ ๋Œ€ํ™”ํ˜• ์š”์†Œ๋ฅผ ํฌํ•จํ•ด์„œ๋Š” ์•ˆ ๋ฉ๋‹ˆ๋‹ค. ๋„ค์ดํ‹ฐ๋ธŒ <button>์„ role="button"์„ ๊ฐ€์ง„ <span>์œผ๋กœ ๊ฐ์‹ธ๋ฉด ์ ‘๊ทผ์„ฑ ํŠธ๋ฆฌ๊ฐ€ ๊ผฌ์ด๊ณ  ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ํ˜ผ๋ž€์„ ๊ฒช์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
  • ํ…์ŠคํŠธ ์˜†์— ์žˆ๋Š” ๊พธ๋ฐˆ์šฉ ์•„์ด์ฝ˜์„ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”๊ฐ€ ์ค‘๋ณตํ•ด์„œ ์ฝ๋Š” ๊ฒƒ์„ ๋ฐฉ์ง€ํ•˜์—ฌ ์ฒญ๊ฐ์  ๋…ธ์ด์ฆˆ๋ฅผ ์ค„์ด๊ณ  ์ •๋ณด ์ „๋‹ฌ์˜ ๋ช…ํ™•์„ฑ์„ ๋†’์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After:
(์‹œ๊ฐ์  ๋ณ€ํ™”๋Š” ์—†์œผ๋ฉฐ, DOM ํŠธ๋ฆฌ์˜ ์ ‘๊ทผ์„ฑ ์†์„ฑ ๊ฐœ์„ ์— ํ•ด๋‹นํ•ฉ๋‹ˆ๋‹ค.)

โ™ฟ Accessibility:

  • ์ค‘์ฒฉ๋œ ๋Œ€ํ™”ํ˜• ์—ญํ•  ์•ˆํ‹ฐํŒจํ„ด์„ ์ œ๊ฑฐํ•˜์—ฌ ์˜ฌ๋ฐ”๋ฅธ ์ ‘๊ทผ์„ฑ ํŠธ๋ฆฌ๋ฅผ ๊ตฌ์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ถˆํ•„์š”ํ•œ ์‹œ๊ฐ ์š”์†Œ์˜ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ๋…ธ์ถœ์„ ์ฐจ๋‹จํ•˜์—ฌ ๋ณด์ด์Šค์˜ค๋ฒ„(VoiceOver) ๋“ฑ ๋ณด์กฐ ๊ธฐ๊ธฐ ์‚ฌ์šฉ ์‹œ ๋” ๊น”๋”ํ•˜๊ณ  ์ง๊ด€์ ์ธ ๋‚ด๋น„๊ฒŒ์ด์…˜์„ ์ œ๊ณตํ•ฉ๋‹ˆ๋‹ค.

PR created automatically by Jules for task 4066132854642119452 started by @seonghobae

- App.tsx, Workspace.tsx ๋‚ด์˜ ๋น„ํ™œ์„ฑํ™”๋œ ๋ฒ„ํŠผ์„ ๊ฐ์‹ธ๋Š” span ํƒœ๊ทธ์—์„œ ๋ถˆํ•„์š”ํ•˜๊ณ  ๋ช…์„ธ์— ์–ด๊ธ‹๋‚˜๋Š” `role="button"` ๋ฐ `aria-disabled="true"` ์ œ๊ฑฐ
- Workspace.tsx, RoleSwitcher.tsx, SectionRoadmap.tsx ๋‚ด์˜ ํ…์ŠคํŠธ์™€ ํ•จ๊ป˜ ํ‘œ์‹œ๋˜๋Š” ๊พธ๋ฐˆ์šฉ(์žฅ์‹์šฉ) Lucide ์•„์ด์ฝ˜๋“ค์— `aria-hidden="true"`๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ค‘๋ณต ์ฝ๊ธฐ ๋ฐฉ์ง€
- ์ด์— ๋งž๊ฒŒ App.test.tsx ์—…๋ฐ์ดํŠธ
Copilot AI review requested due to automatic review settings July 2, 2026 14:06
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Current-head security policy refresh added for this accessibility PR.

Verification run locally on the refreshed head:

  • python3 scripts/checks/verify_supply_chain.py -> passed
  • npm run check:security-notes -> passed
  • git diff --cached --check before commit -> passed

This keeps #540 aligned with the shared RustSec/OSV policy already propagated across the open sale-readiness queue.

@seonghobae seonghobae enabled auto-merge (squash) July 2, 2026 14:15
@google-labs-jules

Copy link
Copy Markdown

Current-head security policy refresh added for this accessibility PR.

Verification run locally on the refreshed head:

  • python3 scripts/checks/verify_supply_chain.py -> passed
  • npm run check:security-notes -> passed
  • git diff --cached --check before commit -> passed

This keeps #540 aligned with the shared RustSec/OSV policy already propagated across the open sale-readiness queue.

Acknowledged.

- App.tsx, Workspace.tsx ๋‚ด์˜ ๋น„ํ™œ์„ฑํ™”๋œ ๋ฒ„ํŠผ์„ ๊ฐ์‹ธ๋Š” span ํƒœ๊ทธ์—์„œ ๋ถˆํ•„์š”ํ•˜๊ณ  ๋ช…์„ธ์— ์–ด๊ธ‹๋‚˜๋Š” `role="button"` ๋ฐ `aria-disabled="true"` ์ œ๊ฑฐ
- Workspace.tsx, RoleSwitcher.tsx, SectionRoadmap.tsx ๋‚ด์˜ ํ…์ŠคํŠธ์™€ ํ•จ๊ป˜ ํ‘œ์‹œ๋˜๋Š” ๊พธ๋ฐˆ์šฉ(์žฅ์‹์šฉ) Lucide ์•„์ด์ฝ˜๋“ค์— `aria-hidden="true"`๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ค‘๋ณต ์ฝ๊ธฐ ๋ฐฉ์ง€
- ์ด์— ๋งž๊ฒŒ App.test.tsx ์—…๋ฐ์ดํŠธ

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

The branch tip moved after the first policy refresh, so I re-applied the same current-head security audit policy on top of the latest #540 head.

Verification run before this push:

  • python3 scripts/checks/verify_supply_chain.py -> passed
  • npm run check:security-notes -> passed
  • staged diff whitespace check -> passed

@google-labs-jules

Copy link
Copy Markdown

The branch tip moved after the first policy refresh, so I re-applied the same current-head security audit policy on top of the latest #540 head.

Verification run before this push:

  • python3 scripts/checks/verify_supply_chain.py -> passed
  • npm run check:security-notes -> passed
  • staged diff whitespace check -> passed

Acknowledged.

- App.tsx, Workspace.tsx ๋‚ด์˜ ๋น„ํ™œ์„ฑํ™”๋œ ๋ฒ„ํŠผ์„ ๊ฐ์‹ธ๋Š” span ํƒœ๊ทธ์—์„œ ๋ถˆํ•„์š”ํ•˜๊ณ  ๋ช…์„ธ์— ์–ด๊ธ‹๋‚˜๋Š” `role="button"` ๋ฐ `aria-disabled="true"` ์ œ๊ฑฐ
- Workspace.tsx, RoleSwitcher.tsx, SectionRoadmap.tsx ๋‚ด์˜ ํ…์ŠคํŠธ์™€ ํ•จ๊ป˜ ํ‘œ์‹œ๋˜๋Š” ๊พธ๋ฐˆ์šฉ(์žฅ์‹์šฉ) Lucide ์•„์ด์ฝ˜๋“ค์— `aria-hidden="true"`๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ค‘๋ณต ์ฝ๊ธฐ ๋ฐฉ์ง€
- ์ด์— ๋งž๊ฒŒ App.test.tsx ์—…๋ฐ์ดํŠธ
@seonghobae

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #541. The Palette branch repeatedly rewrote its head after security policy refresh commits and dropped the required RustSec/OSV policy files; #541 carries the same accessibility fix on a stable develop-based branch with the shared security policy refresh.

@seonghobae seonghobae closed this Jul 2, 2026
auto-merge was automatically disabled July 2, 2026 14:27

Pull request was closed

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #541. The Palette branch repeatedly rewrote its head after security policy refresh commits and dropped the required RustSec/OSV policy files; #541 carries the same accessibility fix on a stable develop-based branch with the shared security policy refresh.

์•Œ๊ฒ ์Šต๋‹ˆ๋‹ค. ์ด ํ’€ ๋ฆฌํ€˜์ŠคํŠธ๊ฐ€ #541์— ์˜ํ•ด ๋Œ€์ฒด๋˜์–ด ํ๊ธฐ๋œ ๊ฒƒ์„ ํ™•์ธํ–ˆ์œผ๋ฉฐ, ์ด ์ž‘์—…์— ๋Œ€ํ•œ ์ถ”๊ฐ€ ์ˆ˜์ •์„ ์ค‘๋‹จํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@opencode-agent

opencode-agent Bot commented Jul 2, 2026

Copy link
Copy Markdown

OpenCode Review Overview

  • Head SHA: da77322fa602f744c4dddbc377d2d5e1411136ab
  • Workflow run: 28597359530
  • Workflow attempt: 1
  • Gate result: APPROVE (exit 0)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (6 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (6 files)"]
  R1 --> V1["required checks"]
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants