Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2023-10-13 - μ„Έμ…˜ νƒ€μž„λΌμΈ 리본 툴팁 ν‚€λ³΄λ“œ μ ‘κ·Όμ„± κ°œμ„ 
**Learning:** 마우슀 ν˜Έλ²„(`onMouseEnter`, `onMouseMove`)μ—λ§Œ μ˜μ‘΄ν•˜μ—¬ νˆ΄νŒμ„ λ„μš°λŠ” μ»€μŠ€ν…€ UI νŒ¨ν„΄μ—μ„œλŠ” ν‚€λ³΄λ“œ μ‚¬μš©μž(Tab ν‚€ 이동)κ°€ 정보λ₯Ό μ „ν˜€ 확인할 수 μ—†λŠ” λ¬Έμ œκ°€ λ°œμƒν•  수 μžˆμŠ΅λ‹ˆλ‹€.
**Action:** μΈν„°λž™ν‹°λΈŒ μš”μ†Œ(λ²„νŠΌ λ“±)에 ν˜Έλ²„ μ•‘μ…˜μ„ μΆ”κ°€ν•  λ•ŒλŠ” 항상 `onFocus`와 `onBlur`λ₯Ό λ³‘ν–‰ν•˜μ—¬ ν‚€λ³΄λ“œ 포컀슀 μ‹œμ—λ„ λ™μΌν•œ μ»¨ν…μŠ€νŠΈ(툴팁 λ“±)κ°€ μ œκ³΅λ˜λ„λ‘ 섀계해야 ν•©λ‹ˆλ‹€.
29 changes: 24 additions & 5 deletions packages/web/src/components/dashboard/session-activity-ribbon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,21 @@ export function SessionActivityRibbon({
const [hover, setHover] = useState<HoverState | null>(null)
const containerRef = useRef<HTMLDivElement>(null)

const trackMouse = useCallback((e: React.MouseEvent) => {
const trackMouse = useCallback((e: React.MouseEvent | React.FocusEvent) => {
const rect = containerRef.current?.getBoundingClientRect()
if (!rect) return e.clientX
return e.clientX - rect.left
if (!rect) {
if ('clientX' in e) return e.clientX
return 0
}
if ('clientX' in e) {
return e.clientX - rect.left
}
// For focus events, calculate the center of the focused element relative to the container
const targetRect = (e.target as HTMLElement).getBoundingClientRect()
return targetRect.left - rect.left + targetRect.width / 2
}, [])

const handleEventHover = useCallback((idx: number) => (e: React.MouseEvent) => {
const handleEventHover = useCallback((idx: number) => (e: React.MouseEvent | React.FocusEvent) => {
setHover({ kind: 'event', idx, x: trackMouse(e) })
}, [trackMouse])

Expand All @@ -173,7 +181,7 @@ export function SessionActivityRibbon({
toolName: string,
count: number,
firstEvent: TimelineEvent,
) => (e: React.MouseEvent) => {
) => (e: React.MouseEvent | React.FocusEvent) => {
setHover({
kind: 'merged',
firstIdx,
Expand All @@ -200,6 +208,8 @@ export function SessionActivityRibbon({
onMouseEnter={handleEventHover(idx)}
onMouseMove={handleEventHover(idx)}
onMouseLeave={() => setHover(null)}
onFocus={handleEventHover(idx)}
onBlur={() => setHover(null)}
aria-label={`Event ${idx + 1}`}
aria-current={selected ? 'true' : undefined}
className={`h-full ${bg} transition-opacity ${
Expand All @@ -225,6 +235,8 @@ export function SessionActivityRibbon({
onMouseEnter={handleEventHover(idx)}
onMouseMove={handleEventHover(idx)}
onMouseLeave={() => setHover(null)}
onFocus={handleEventHover(idx)}
onBlur={() => setHover(null)}
aria-label={`Event ${idx + 1}`}
aria-current={selected ? 'true' : undefined}
className={`h-full ${bg} transition-opacity ${
Expand Down Expand Up @@ -288,6 +300,13 @@ export function SessionActivityRibbon({
group.items[0].event,
)}
onMouseLeave={() => setHover(null)}
onFocus={handleMergedHover(
firstIdx,
group.toolName,
group.items.length,
group.items[0].event,
)}
onBlur={() => setHover(null)}
aria-label={`Expand ${group.toolName} group, ${group.items.length} events`}
className={`relative h-full ${segmentVisuals(group.items[0].event).bg} transition-opacity hover:opacity-70`}
>
Expand Down
Loading