Repository navigation
π¨ Palette: μ₯μμ© μμ΄μ½μ aria-hidden μΆκ° - #788
seonghobae wants to merge 1 commit into
Conversation
- λΆνμν μ€ν¬λ¦° 리λ μμ± μΆλ ₯μ λ°©μ§νκΈ° μν΄ μ₯μμ© μμ΄μ½μ `aria-hidden="true"` μμ±μ μΆκ°ν¨ - `packages/web/src/components/ui/pagination.tsx` (ChevronLeftIcon, ChevronRightIcon) - `packages/web/src/components/dashboard/reports/week-navigator.tsx` (ChevronLeft, ChevronRight) - `packages/web/src/components/dashboard/reports/context-section.tsx` (ChevronUp, ChevronDown) - `packages/web/src/components/dashboard/event-detail.tsx` (X, Icon) - `packages/web/src/components/dashboard/event-list.tsx` (Icon, ChevronRight)
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review info
π Walkthrough
Merge Risk: βͺ Minimal Β· up to This change hides decorative icons from screen readers while retaining the surrounding labels and accessible names; no merge-blocking risk is evident. Pre-merge checks |
|
π‘ What
aria-hidden="true"μμ±μ μΆκ°νμ΅λλ€. (μ΄ 5κ° νμΌ)π― Why
aria-labelμ΄ μλ μμ μλ¦¬λ¨ΌνΈ λ΄λΆμ μμ λ μ€ν¬λ¦° 리λκ° λΆνμνκ² μμ΄μ½μ λ€μ μ½μ§ μλλ‘ νμ¬ μ κ·Όμ±μ ν₯μμν΅λλ€.πΈ Before/After
βΏ Accessibility
PR created automatically by Jules for task 1966716075761519870 started by @seonghobae
Summary by CodeRabbit