Repository navigation
fix(mlx): refuse non-finite and incomplete native parity output - #755
seonghobae wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Exact-head publication and hosted execution blockerThis four-path source candidate is committed as Hosted failure is currently non-execution, not a source test result: foundation job No repeated workflow rerun, billing change, runner registration, approval, Ready transition or merge was performed. Preserve organization-wide self-hosted migration ownership and normal checks. The independent #538 rustls/#648 admission prerequisites remain separate. Prior composition-local coverage100% is not hosted current-head evidence or standalone policy approval. CodeRabbit draft skip and Devin credit-limited skip are not qualifying review. |
Correctness defect
The macOS-native MLX CPU probe previously reduced output differences through
f64::max, allowing one NaN or a truncated zip to produce a false exact-zero parity receipt. The permanent rejection assertions were observed failing before the finite/shape guard was added.Scope
This PR carries only four MLX-owned paths: the private receipt/FFI boundary and regression tests, its research note, changelog fragment and documentation index entry. It does not duplicate the six-file prerequisite repair already owned by #538 (rustls advisory) and #648 (central-hourly admission).
The private native-call table preserves production pinned C ABI calls and actual handle creation/free order. Injected device/matmul/evaluation/null-data controls delegate real native frees; these are test fixtures, not observations of native hardware faults. All native tests share a cfg(test)-only mutex after a retained SIGTRAP exposed concurrent native runtime entry. Real native MLX positive execution remains required.
Verified evidence and boundaries
The complete local ten-file composition (this delta plus exact #538/#648 prerequisite slices) passed 1,448 Rust tests/doctests, warning-fatal Clippy/rustdoc, source-aware line 11,209/11,209 and folded branch 3,900/3,900 gates, native package build and whole-source independent review. These are composition-local results, not standalone PR CI or qualifying GitHub approval. The inherited sqlx_live.rs producer exclusion is unchanged; supplementary native PostgreSQL18 is not pinned16 hosted evidence. MLX CPU probe is not Metal/GPU estimator parity.
Prior failed coverage, SIGTRAP and rejected review are retained. No thresholds, exclusions, scientific target, public contract, PRD meaning or protection were weakened.
Required before main integration