Repository navigation
fix: give public boundary errors a stable standard contract - #331
seonghobae wants to merge 2 commits into
Conversation
Origin, action-intent digest, extension identifier, and evidence failures now implement Display and std::error::Error. Each typed variant keeps one stable message, and the error carries no source that could widen the failure into another authority.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (9)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughcore 및 evidence 오류 타입에 Changes표준 오류 계약
SHA-256 provenance 특성화
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue remains; merge after the pending exact-head checks complete. Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The new error interface exposes fixed category messages without underlying error chains. Validation and sensitive operations remain unchanged, and no material security risk introduced or worsened by this PR was found. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 46.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 7 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
CHANGELOG.md— repository behaviorcrates/originweave-core/src/lib.rs— Rust workspace crate API and testscrates/originweave-core/tests/action_intent_error_contract.rs— Rust workspace crate API and testscrates/originweave-core/tests/extension_id_error_contract.rs— Rust workspace crate API and testscrates/originweave-core/tests/origin_error_contract.rs— Rust workspace crate API and testscrates/originweave-evidence/src/lib.rs— Rust workspace crate API and testscrates/originweave-evidence/tests/evidence_error_contract.rs— Rust workspace crate API and tests
Changed behavior
classDiagram
class Origin
class parse
class as_str
class scheme
class host
class OriginError
class BrowserSessionId
class BrowsingContextId
Changed API
Originparseas_strschemehostOriginErrorBrowserSessionIdBrowsingContextIdDocumentEpochObservedNodeHandlenewvalidate_currentNodeHandleErrorActionIntentDigestActionIntentDigestErrorSessionModeExecutionPurposeInstructionSourceRobotsDecisionSecretDeliveryRiskClassCapabilityActionKindApprovalScopeApprovalEvidenceauthorizesActionRequestPolicyContextset_approvalExtensionIdExtensionIdErrorExtensionAgentCapabilityExtensionAgentGrantExtensionAccessRequestExtensionAccessDecisionevaluate_extension_accessHttpMethodEvidenceSourceKindVerificationResultEvidenceErrorNetworkEvidencecapturepathProvenanceRecordsource_urlsource_locatorsource_hash
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
3247c31bcd47498533faf87c35798de5c4c54052 - Workflow run: 36422188944
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
classDiagram
class Origin
class parse
class as_str
class scheme
class host
class OriginError
class BrowserSessionId
class BrowsingContextId
OpenCode Review Overview
Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment. |
1 participant
Summary
Displayandstd::error::Error.Test plan
cargo test --offline -p originweave-core --test origin_error_contract --test action_intent_error_contract --test extension_id_error_contractcargo test --offline -p originweave-evidence --test evidence_error_contractSummary by CodeRabbit
Numeric provenance successor — published 2026-10-05 KST
Current head
b14493be78fd020ce23f28aebcb1a123dabdaec1follows3247c31bcd47498533faf87c35798de5c4c54052, reviewed treec4c3718c4e50451ab27b086a7bfde082c99b1693. Independent complete original-base-to-final SOURCE report SHA-256016e37898ea143cb56b76e8d54301ed97583e925e7e5551415f7f8ab2cde532fcovers all nine changed paths and218 source files, including the inherited core/evidence Display/Error implementations. Only evidence.rs, TEST_STRATEGY and CHANGELOG changed in this increment. Inherited production error behavior is preserved; the latest increment is test-only.Numeric-only SHA-256 construction and exact source_hash retention are now asserted with the original64-digit positive. Existing mixed-hex positives, malformed hash/URL/locator negatives and error contracts remain unchanged. First-GREEN characterizes correct existing production; two isolated mutations (requiring a hex letter or truncating only numeric hashes) each retain all seven old controls while failing the new assertion, then all seven tests pass after exact restoration. No ordinal enum or additional policy contract was introduced. The independent suggestion for future failing fmt::Write sink controls was not folded into these reviewed bytes.
Actual adopted checkout formatting and8 focused tests passed before a normal commit. Fresh exact committed-head nine gates passed: Rust280/Python152, failedignored0, strict rustdoc, functions525/525, lines4448/4448, regions5385/5385, branches654/654, all100%. Committed coverage SHA-256
f5436854168b5bc386216ca8199c91c55de20f43e6c975b66316cb97db4fb1c3is separate from private-candidate coverage. Initial fulltest hit350seconds after compilation consumed346seconds; actual exit-15/timed_outtrue/groupempty and partial log are retained. Only that incomplete gate was repeated with unchanged source/target/command/350-second child deadline and a distinct log; full PASS followed. The private author’s earlier UNKNOWN child exit remains historical and is not retroactively repaired.One normal non-force push through the existing verified same-identity personal S1 route succeeded after bundle1717B/hash/parent/tree/increment/source218 verification. Sixteen stage logs and owned-group settlement are bound. Initial PR-ref propagation lag was retained; authenticated PRhead and branch/PRrefs then matched without another push. Credential transfer, persistent helper/configuration, billing, group/ACL, workflow/protection, readiness, rerun and merge changes are zero.
Actual new-head runs37237503344 jobs111539462286/111539462419, MV337237503348 job111539462234 and managed37237501081 job111539458704 all have runner_id0/steps[] and explicit billing startup/not-started annotations. These are not executed test/coverage/browser/scanner failures. Current non-Draft status is preserved. CodeRabbit pending/Devin SUCCESS are not counted current-head approval. Hosted acceptance, any required eligible approval, ordinary protected merge and the original Goal remain incomplete.