Skip to content

Fix OpenCode inline review fallback warning#10

Merged
seonghobae merged 1 commit into
mainfrom
codex/opencode-inline-diff-fallback
Jun 21, 2026
Merged

Fix OpenCode inline review fallback warning#10
seonghobae merged 1 commit into
mainfrom
codex/opencode-inline-diff-fallback

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • remove the missing warn_gh_publication_failure dependency from the inline review fallback path
  • keep the OpenCode suggested diff contract unchanged: structured findings use GitHub review comments, and fallback reviews explain why inline anchoring failed

Validation

  • git diff --check
  • Ruby YAML parse for .github/workflows/opencode-review.yml
  • contract marker check for create_pull_review_with_payload, comments array, suggested diff body, and fallback warning

@seonghobae seonghobae enabled auto-merge June 21, 2026 09:29
@github-actions

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 5c55b0dcc78f27afc855a612d79a198e119a908a
  • Workflow run: 27900079066
  • Workflow attempt: 1
  • Gate result: APPROVE (exit 0)

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode Agent approved this PR.

The change in the workflow script replaces a call to warn_gh_publication_failure with the function's body, which is safe because the function's behavior is preserved and the added event variable in the message improves context. The function remains defined and used elsewhere appropriately.

  • Result: APPROVE
  • Reason: Change replaces a function call with equivalent inlined code, improving clarity by including the event type. No functional, security, or privacy issues found.
  • Head SHA: 5c55b0dcc78f27afc855a612d79a198e119a908a
  • Workflow run: 27900079066
  • Workflow attempt: 1

@seonghobae seonghobae merged commit 3580ec3 into main Jun 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant