Skip to content

fix(review): order review models by GitHub Models quota, not gpt-5 first #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Jul 5, 2026
+22 −14
Merged

fix(review): order review models by GitHub Models quota, not gpt-5 first #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/opencode-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2280,7 +2280,14 @@ jobs:
SHARE: "false"
NPM_CONFIG_IGNORE_SCRIPTS: "true"
NO_COLOR: "1"
OPENCODE_MODEL_CANDIDATES: "github-models/openai/gpt-5 github-models/openai/gpt-5-chat github-models/deepseek/deepseek-v3-0324 github-models/openai/o3 github-models/deepseek/deepseek-r1 github-models/openai/o4-mini github-models/openai/o3-mini github-models/openai/gpt-5-mini github-models/mistral-ai/mistral-medium-2505 github-models/openai/gpt-5-nano github-models/deepseek/deepseek-r1-0528 github-models/meta/llama-4-maverick-17b-128e-instruct-fp8 github-models/meta/llama-4-scout-17b-16e-instruct"
# Ordered by GitHub Models quota allowance, largest first, so the
# highest-throughput models review before the rate-starved flagships.
# gpt-5/o3 are "Reasoning" tier (8-12 req/day) — putting them first
# (as before) stalled every review until the step timed out, because
# a rate-limited/hung flagship never fell back. Non-reasoning "Low"
# tier (deepseek-v3, mistral, llama-4: 150-450 req/day) and mini
# reasoning models go first; gpt-5 stays last as a quality fallback.
OPENCODE_MODEL_CANDIDATES: "github-models/deepseek/deepseek-v3-0324 github-models/mistral-ai/mistral-medium-2505 github-models/meta/llama-4-maverick-17b-128e-instruct-fp8 github-models/meta/llama-4-scout-17b-16e-instruct github-models/openai/o4-mini github-models/openai/o3-mini github-models/openai/gpt-5-mini github-models/openai/gpt-5-nano github-models/openai/gpt-5-chat github-models/deepseek/deepseek-r1-0528 github-models/deepseek/deepseek-r1 github-models/openai/o3 github-models/openai/gpt-5"
OPENCODE_MODEL_ATTEMPTS: "5"
OPENCODE_RUN_TIMEOUT_SECONDS: "20400"
OPENCODE_EXPORT_TIMEOUT_SECONDS: "120"
Expand Down
27 changes: 14 additions & 13 deletions tests/test_opencode_agent_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ def test_opencode_model_pool_sets_high_effort_for_capable_candidates():
assert candidate_models
assert set(candidate_models).issubset(set(models))
assert candidate_models[:3] == [
"openai/o4-mini",
"openai/o3-mini",
"openai/gpt-5-mini",
"deepseek/deepseek-v3-0324",
"mistral-ai/mistral-medium-2505",
"meta/llama-4-maverick-17b-128e-instruct-fp8",
]
assert {
"openai/gpt-5-chat",
Expand Down Expand Up @@ -282,25 +282,26 @@ def test_workflow_provisions_sandbox_tool_and_reviewer_agent():
assert "publish REQUEST_CHANGES when coverage-evidence blocker states" in workflow
assert re.search(r"opencode-review-target:[\s\S]{0,240}timeout-minutes: 360", workflow)
assert 'timeout-minutes: 75' in workflow
assert re.search(r"Run OpenCode PR Review model pool[\s\S]{0,240}timeout-minutes: 285", workflow)
assert re.search(r"Run OpenCode PR Review model pool[\s\S]{0,240}timeout-minutes: 350", workflow)
assert 'APPROVAL_CHECK_WAIT_ATTEMPTS: "81"' in workflow
assert 'APPROVAL_CHECK_WAIT_SLEEP_SECONDS: "30"' in workflow
assert (
'OPENCODE_MODEL_CANDIDATES: "github-models/openai/o4-mini '
'OPENCODE_MODEL_CANDIDATES: "github-models/deepseek/deepseek-v3-0324 '
"github-models/mistral-ai/mistral-medium-2505 "
"github-models/meta/llama-4-maverick-17b-128e-instruct-fp8 "
"github-models/meta/llama-4-scout-17b-16e-instruct "
"github-models/openai/o4-mini "
"github-models/openai/o3-mini "
"github-models/openai/gpt-5-mini "
'github-models/openai/gpt-5-chat '
"github-models/openai/o3 "
"github-models/mistral-ai/mistral-medium-2505 "
"github-models/openai/gpt-5-nano "
'github-models/openai/gpt-5-chat '
"github-models/deepseek/deepseek-r1-0528 "
"github-models/deepseek/deepseek-r1 "
"github-models/deepseek/deepseek-v3-0324 "
"github-models/meta/llama-4-maverick-17b-128e-instruct-fp8 "
'github-models/meta/llama-4-scout-17b-16e-instruct"'
"github-models/openai/o3 "
'github-models/openai/gpt-5"'
) in workflow
assert 'OPENCODE_MODEL_ATTEMPTS: "1"' in workflow
assert 'OPENCODE_RUN_TIMEOUT_SECONDS: "600"' in workflow
assert 'OPENCODE_MODEL_ATTEMPTS: "5"' in workflow
assert 'OPENCODE_RUN_TIMEOUT_SECONDS: "20400"' in workflow
assert 'OPENCODE_EXPORT_TIMEOUT_SECONDS: "120"' in workflow
assert 'OPENCODE_TOTAL_RETRY_BUDGET_SECONDS: "0"' in workflow
assert 'OPENCODE_BACKOFF_MAX_SECONDS: "30"' in workflow
Expand Down
Loading