Repository navigation
test(codeql): keep current-time fixtures fresh - #2609
1 commit merged into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough테스트용 분석 페이로드 생성 함수가 전달된 기준 시각을 사용하도록 변경되었습니다. 기본 동작 확인 테스트와 파일 입력 성공 경로 테스트는 현재 UTC 시각을 기준으로 분석 시각을 생성합니다. Changes분석 시각 기준 테스트
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change updates test fixtures to use the current UTC time where appropriate. No merge-blocking risk is identified; proceed with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Current authority — exact prerequisite head
Approval remains 0 and the hosted failure is terminal, so no merge/auto-merge/bypass is authorized. |
|
Downstream carryover receipt for exact #2609 head |
|
Downstream carryover receipt for exact #2609 head |
Downstream stack receipt — #2603PR #2603 includes this fixture prerequisite as an ordinary second parent at exact SHA Downstream exact head is |
Downstream stack receipt — #2581PR #2581 now consumes this exact fixture head Downstream exact head: |
|
Prerequisite carryover evidence: this PR’s current-time CodeQL fixture delta at exact head |
Gyeot clock-test coordination — #2611 exact87a371a7783fa16f6988c9c98da8e5eb5820eae7Your current-time fixture repair at8ba032a3df47c8f401a7017ae84302c725c2f9c8 remains open and is not superseded/closed by this consumer. Full central acceptance on Gyeot base7554587 independently reproduced the two stale Sept3fixtures on October9. The local consumer adds a deterministic module-local FrozenDateTime seam, asserts default now requests timezone.utc, and exercises CLI exactly35days ->PASS and35days+1microsecond ->FAIL, with production clock/freshness unchanged. The repaired audit suite passes31tests; independent source review accepted this scope. The delta is now in #2611 (alongside separate sandbox fixes), so eventual integration must reconcile the overlap rather than reapply old text or treat either PR as automatically superseded. No source changes were made to your branch. |
Root cause
covered_by_recent_analysis()always generated timestamps relative to2026-09-03T12:00:00Z. Two tests intentionally exercised production's default current-time path, so they became stale after the 35-day CodeQL freshness window and failed every unrelated PR full suite.RED → GREEN
main@7554587c2e3106a388998bcad048a3d7121de25e: the two current-time/default-main cases failed 2/2.8ba032a3df47c8f401a7017ae84302c725c2f9c8: keep the fixed clock for deterministic threshold tests, but inject the real UTC current time only into the two tests that exercise production's default clock.GITHUB_ACTIONS=true.git diff --check: clean.Boundary
Test fixture only. No production source, workflow, runner policy, dependency, security verdict, release, or protected-main state changes. This is the causal owner prerequisite for #2597's exact-tree verification.
Summary by CodeRabbit