Skip to content

fix(ci): prepare orchestrator closures before provider credentials - #2494

Draft
seonghobae wants to merge 2 commits into
codex/co-external-review-gatewayfrom
codex/tool-closure-prescreen-20260928
Draft

seonghobae wants to merge 2 commits into
codex/co-external-review-gatewayfrom
codex/tool-closure-prescreen-20260928

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Review, autofix, and release workflows clone and hash-install the pinned contextual-orchestrator closure in an uncredentialed --prepare step. Launch checks that receipt and does not clone or install again.
  • tool-identity refuses a symlink, a non-exact commit, a dirty tree, or a lock that is not a hash pin.
  • The licence-judged release installer passes --no-deps, so that closure is not re-resolved.
  • tool-environment still license-gates a synthetic tool closure in tests. Review workflows do not call it: the exact-text registry does not cover the live orchestrator lock, and the release workflow already records that judgement as an owner decision.

Tests

Focused pytest, with plugin autoload disabled: 17 tool-environment tests, 131 sidecar/workflow/lock contract tests, and 7 adjacent Noema/taxonomy tests passed. Ruff passed on the edited Python files. bash -n passed on the edited shell scripts.

This does not claim a hosted check result or a licence verdict on pin 01bf92a3ec67a0e1f9b68978eb16b60301e985fd.

Current authority — 2026-10-09

Exact head: c530cbcd4b0426ec6b18e99e8f1b5a6b4cf9368b
Canonical prerequisite: #1963 exact head 0b15f3e667e9afceb3d4317144e03a646389b2b3

This branch was reconciled non-destructively with #1963 as a two-parent merge and is stacked on that prerequisite. The effective stack delta is 16 files. The merge preserves the external gateway's empty released-adapter registry and fail-closed behavior while keeping tool-closure preparation uncredentialed. The disk-capacity guard now runs inside --prepare, before clone or venv I/O.

Local verification on the exact tree 66e9d4f9c79592c497c221bb7799f4a94f081a2e:

  • 182 focused tests passed normally.
  • The same 182 focused tests passed with GITHUB_ACTIONS=true.
  • Full suite: 5,243 passed, 11 skipped, 40 subtests passed; two date-stale baseline failures remain in tests/test_audit_org_codeql_coverage.py and are already owned by ci(fast-mlsirm): centralize checks on isolated runners #2607.
  • Shell syntax and cached-diff checks passed.

Draft remains authoritative: #1963 is still Draft and contextual-orchestrator has no verified immutable release tag for the external adapter. Hosted exact-head review/check admission is not claimed.

Move the pinned contextual-orchestrator clone and hash-bound install into an
uncredentialed prepare step, refuse inexact tool locks, and install a
licence-judged release closure with --no-deps.
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact-head admission correction — 1068547f59660a45c83b531512301664c5928b84

Ready is review admission only. Fresh audit against base 3295c259bcb688673170a1902f46d1d6c775bad4 found:

  • mergeability=false on current base
  • latest terminal workflow blockers: SAST Semgrep 36423660986=failure, Security Scan 36423660961=failure, Python Security 36423660906=failure, CodeQL PR 36423660921=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

@seonghobae
seonghobae marked this pull request as draft September 30, 2026 05:22
@seonghobae
seonghobae changed the base branch from main to codex/co-external-review-gateway October 9, 2026 08:01

Copy link
Copy Markdown
Contributor Author

Current authority — exact head c530cbcd4b0426ec6b18e99e8f1b5a6b4cf9368b

The stale/conflicted branch was repaired without force push or rebase:

  • ordinary two-parent merge: previous head 1068547f59660a45c83b531512301664c5928b84 + canonical prerequisite feat(review): add proposed external gateway admission port #1963 head 0b15f3e667e9afceb3d4317144e03a646389b2b3
  • exact tree: 66e9d4f9c79592c497c221bb7799f4a94f081a2e
  • base retargeted to codex/co-external-review-gateway; effective delta: 16 files, +520/-55
  • resolved the three overlap conflicts while preserving both intents: external token-only fail-closed admission and uncredentialed tool-closure preparation
  • moved the runner disk guard into --prepare before clone/venv I/O; retained RED→GREEN coverage for exhausted, low, and sufficient disk
  • focused: 182/182 passed; same 182/182 with GITHUB_ACTIONS=true
  • full: 5,243 passed, 11 skipped, 40 subtests passed; two date-stale baseline failures in tests/test_audit_org_codeql_coverage.py are already owned by ci(fast-mlsirm): centralize checks on isolated runners #2607

Draft remains authoritative because #1963 is an unready mutable prerequisite and contextual-orchestrator has no verified immutable external-adapter release tag. The exact-head CodeQL event is skipped and there is no approval. No rerun, wake-only commit, bypass, merge, Close, force push, or destructive rebase was performed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant