Skip to content

fix(strix): accept legal Git path punctuation #606

Description

@seonghobae

Problem

The central Strix required workflow rejects a legal Git path containing comma and parentheses while auditing ContextualWisdomLab/aFIPC#160. The changed path is quoted and passed after a Git double-dash boundary, but the bounded character allowlist currently classifies it as unsafe and exits 2 before scanning.

Acceptance criteria

  • Accept comma and parentheses in normalized repository-relative paths.
  • Preserve fail-closed rejection of absolute paths, traversal, leading or trailing whitespace, alternate separators, control characters, bidi controls, and Git pathspec syntax.
  • Add an integration regression proving a legal punctuated path is materialized from the validated PR head as non-executable scan data.
  • Pass the focused Strix gate test, required-workflow smoke test, shell syntax checks, and diff hygiene.

Agent: Codex
Recorded: 2026-07-21T12:00:00+09:00
Phase: Ops

Activity

  1. moved this from Todo to In Progress in naruon Platform Roadmapon Jul 21, 2026
  2. seonghobae commented on Aug 7, 2026

    @seonghobae
    ContributorAuthor

    Completed by protected merge #800. Exact accepted head dc7748a3af4fe755b27b784edd82dd35d7ee8e43 merged as 1131b1bbafb24e455fc8619cdf316813e8721861 on 2026-08-07. The integrated repair admits comma and ASCII parentheses while retaining raw-traversal, absolute/control/backslash/shell-punctuation and out-of-root rejection, and its exact-head Strix quality, security, SAST, CodeQL, secret, OSV, Scorecard, SBOM, review-thread, and independent-review gates were satisfied before protected merge. Closing this issue as completed; no predecessor failure is reused as acceptance evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions