Skip to content

fix(payments): harden client payment attempts and retries - #108

Open
1amKhush wants to merge 2 commits into
ContextVM:masterfrom
1amKhush:fix/payment-client-lifecycle
Open

1amKhush wants to merge 2 commits into
ContextVM:masterfrom
1amKhush:fix/payment-client-lifecycle

Conversation

@1amKhush

@1amKhush 1amKhush commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Closes #107

Summary

Repeated offers and delayed callbacks could repeat wallet work or retry completed requests.

  • Validate payment offers, options, and configuration before wallet callbacks.
  • Retain payment-attempt outcomes and add per-invocation amount, attempt, and deadline limits.
  • Cancel retries and fence callbacks on completion, cancellation, or close.
  • Preserve request identity and enforce deliverable Nostr retries.
  • Add regression coverage for request generations and both encryption modes.

Validation

  • Full concurrent suite: 693 passed, 5 live-wallet tests skipped, 0 failures.
  • Typecheck, lint, build, and export checks passed.
  • 100 focused tests passed; 19 regression cases reproduced failures on the original baseline.

Notes

  • Amount limits apply to advertised amounts; wallet handlers must verify payment payloads.
  • Attempt history is bounded and refuses new payments at capacity.
  • Full browser bundling encounters a pre-existing applesauce-relay resolution error; helper bundles and the wrapper with that dependency externalized passed.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 20:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harden client payment attempts and retry lifecycle

2 participants