Repository navigation
Conversation
added 2 commits
October 12, 2026 09:29
…as invalid Implement the documented NIP05_DOMAIN_COOLDOWN_SECONDS. The resolver now distinguishes a definitive negative answer (unknown name, non-retryable HTTP status, malformed document) from a transport failure (network, TLS, timeout, 429, 5xx). Transport failures put the domain on hold in the persistent NIP-05 cache store, and the refresh stage skips the remaining names of a domain on hold instead of waiting for each lookup to time out.
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A temporary NIP-05 server outage does not invalidate a user's identifier. Caching it as a negative answer can reject valid users long after recovery.
Change
Persist domain cooldowns for network/TLS errors, timeouts, 429 and 5xx. Include connection failures while reading the response body. Keep definitive negatives, including malformed JSON, cached normally.
Verification
Bun 1.3.14/macOS; temporary test
SERVER_SECRET_KEY. Existing manager and duplicate-DuckDB type errors remain. Independent PR; does not address separate NIP-05 plugin errors.Related: #15, #16, #18, #19. All branches are independent; combined suite: 221 pass, 5 skip, 0 fail.