Conversation
|
needs to be updated after Consensys/gnark-crypto#313 and Consensys/gnark-crypto#314 get merged in gnark-cypto. |
|
So, right now there is a slight problem - when we sign with gnark-crypto, as a signature we get a I have some ideas and will try to push the changes. |
ivokub
left a comment
There was a problem hiding this comment.
Rebased on top of develop, added a few more changes (avoid explicit conversion to *big.Int, rename package import, update go.mod).
Previously I totally overthought it. I think the simple approach is better (read signature directly into secp256k1 ECDSA signature struct and get R and S from there).
As far as it seems then the failing tests are due to MiMC hashing. Imo are unrelated to this PR.
Use gnark-crypto instead of geth/crypto for secp256k1 and ecdsa.
This needs Consensys/gnark-crypto#310 to be merged first.