Skip to content

Remove global icon imports#437

Open
MikeLockz wants to merge 32 commits intomasterfrom
ml-remove-icon
Open

Remove global icon imports#437
MikeLockz wants to merge 32 commits intomasterfrom
ml-remove-icon

Conversation

@MikeLockz
Copy link
Contributor

Entire rimble-ui library is now tree-shakeable. Icons are separated to a new repo.

Before: (rimble-ui + dependencies size ~1.89MB)
image

After: (rimble-ui + dependencies size ~300KB)
image

Fixes #436

Mike Lock added 21 commits December 2, 2019 14:04
…e.json. Point module property value in package.json to /dist/es directory. Updated demo app to allow for production bundle analysis. Tree shaking works when building es modules manually via babel command line.
# Conflicts:
#	demo/package.json
#	demo/yarn.lock
#	package.json
#	yarn.lock
@MikeLockz MikeLockz added the enhancement New feature or request label Dec 30, 2019
@MikeLockz MikeLockz self-assigned this Dec 30, 2019
@netlify
Copy link

netlify bot commented Dec 30, 2019

Deploy preview for rimble-ui-storybook ready!

Built with commit 46e9798

https://deploy-preview-437--rimble-ui-storybook.netlify.app

@MikeLockz MikeLockz requested review from a team and gesquinca December 30, 2019 21:43
Mike Lock added 2 commits February 25, 2020 12:27
# Conflicts:
#	demo/src/App.js
#	package.json
#	src/Button/BaseButton.js
#	src/Button/__snapshots__/Button.test.js.snap
#	src/Checkbox/__snapshots__/Checkbox.test.js.snap
#	src/Checkbox/index.js
#	src/EthAddress/__snapshots__/EthAddress.test.js.snap
#	src/Form/__snapshots__/form.test.js.snap
#	src/Icon/__snapshots__/Icon.test.js.snap
#	src/Input/__snapshots__/FileInput.test.js.snap
#	src/Input/index.js
#	src/Radio/__snapshots__/Radio.test.js.snap
#	src/Radio/index.js
#	src/Select/__snapshots__/Select.test.js.snap
#	src/ToastMessage/__snapshots__/ToastMessage.test.js.snap
#	src/Tooltip/__snapshots__/Tooltip.test.js.snap
#	src/index.js
#	yarn.lock
Michael Lockwitz and others added 7 commits March 26, 2020 11:34
# Conflicts:
#	demo/src/App.js
#	demo/yarn.lock
#	package.json
#	src/Button/__snapshots__/Button.test.js.snap
#	src/Checkbox/index.js
#	src/EthAddress/__snapshots__/EthAddress.test.js.snap
#	src/Icon/__snapshots__/Icon.test.js.snap
#	src/Icon/index.js
#	src/Input/__snapshots__/FileInput.test.js.snap
#	src/Input/index.js
#	src/Radio/index.js
#	src/Select/__snapshots__/Select.test.js.snap
#	src/Select/index.js
#	src/ToastMessage/__snapshots__/ToastMessage.test.js.snap
#	src/Tooltip/__snapshots__/Tooltip.test.js.snap
#	yarn.lock
@withthelemons
Copy link

Any news? This is important for an app my company is working on.

geoknee added a commit to statechannels/statechannels that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor global icon import out of library

3 participants

Comments