refactor: Simplify predicate notification system #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in the same order that they are returned
maartenflippo
previously requested changes
Jan 27, 2026
Contributor
maartenflippo
left a comment
maartenflippo
left a comment
There was a problem hiding this comment.
We should take into account that we do not track predicates becoming false.
| #[derive(Clone, Copy)] | ||
| struct TrackedValue { | ||
| value: i32, | ||
| flags: u8, |
Contributor
There was a problem hiding this comment.
Can be done using EnumSet. It will have the same packing
Comment on lines
78
to
88
| impl Debug for TrackedValue { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| f.debug_struct("TrackedValue") | ||
| .field("value", &self.get_value()) | ||
| .field( | ||
| "PredicateTypes", | ||
| &self.get_predicate_types().collect::<Vec<_>>(), | ||
| ) | ||
| .finish() | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
When using enumset, this can be derived
maartenflippo
previously requested changes
Jan 27, 2026
Contributor
maartenflippo
left a comment
maartenflippo
left a comment
There was a problem hiding this comment.
Please add tests to the PredicateTracker
github-actions
bot
dismissed stale reviews from maartenflippo and maartenflippo
Review re-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the predicate notification system is convoluted and carries a lot of duplicate information with several levels of indirection to reach a specific tracker for a predicate type.
This PR addresses this issue by merging all of these trackers for different types into a single
PredicateTracker, which keeps track of the status of all predicate types at once.To accomodate this, two new
TrailedIntegers are required, which, rather than being moved when a bound is greater (lesser) than or equal to the tracked value, are moved when the bound is strictly greater (lesser) than the tracked value. This allows us to track all of the different predicate types using a single tracker.TODO
Vec<Vec<PredicateType>>to track which predicates are attached to a value.However, we can use 4 bits to store this information more conciselyUsing only 27 bits for representation was too little, so it is now stored as with an additional EnumSet