Open
Conversation
The Team api appears to do a deep fetch so additional fetches of player objects are redundant.
This doesn't work as expected, I suspect that the Team api call isn't saving the player values properly. If you save the newly added player the data gets stored somewhere but a new _id is not generated for that player. Obviously this screen still needs the ability to actually set/change the players values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stephenvisser here is the barely started work I was doing to #47. As mentioned in the comment, a newly injected player into currentTeam.players array gets save somewhere but I get the feeling something isn't actually saving/working as probably intended. Sorry I didn't have time to do more doing