Skip to content

Fixed count of votes cast - #108

Merged
pikachu0542 merged 2 commits into
devfrom
fix-votes-cast
Apr 8, 2026
Merged

pikachu0542 merged 2 commits into
devfrom
fix-votes-cast

Conversation

@pikachu0542

Copy link
Copy Markdown
Member

What

Fixed count of votes cast

Why

So that it actually shows the correct number

Test Plan

run locally

Env Vars

nope

Documentation

nope

Checklist

  • Tested all changes locally

@pikachu0542 pikachu0542 self-assigned this Apr 8, 2026
@pikachu0542 pikachu0542 added the bug Something isn't working label Apr 8, 2026
@csh-sonarqube-community

Copy link
Copy Markdown

Failed Quality Gate failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Project ID: ComputerScienceHouse_vote_c5ba863d-30d7-4fa9-97dd-4f2c58f8f5fa

View in SonarQube

@BigSpaceships BigSpaceships left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pikachu0542
pikachu0542 merged commit c940095 into dev Apr 8, 2026
2 of 3 checks passed
@pikachu0542
pikachu0542 deleted the fix-votes-cast branch April 8, 2026 20:48
pikachu0542 added a commit that referenced this pull request Apr 9, 2026
* Fixed count of votes cast

* Misc fixes
BigSpaceships added a commit that referenced this pull request Oct 3, 2026
* Bootstrap 5 upgrade (#106)

* Changed all status codes to the http.StatusCode equivalent. Also changed some 500s to 400s where appropriate to indicate user error (#85)

* Started working on navbar

* More progress

* working theme selector

* Eboard vote link appears on all pages

* Started working on navbar

* More progress

* working theme selector

* Rebase with dev

* Finished rebasing with dev

* Added favicon import

* Misc other stuff, navbar is responsive now

* larger nav title

* Quorum text input, create page basically done

* Finished poll creation page

* Ranked choice poll page is done

* Actually use the hidden template

* changed icon

* Fixed vote count on eboard votes

* Added display of total votes submitted to results

* small fixes

* fixed spacing between buttons for eboard vote on mobile

* poll title wrapping in a different place

* Changed underline to bold

* Capitalize description placeholder text

---------

Co-authored-by: Noah Hanford <bigspaceships56@gmail.com>

* Fixed count of votes cast (#108)

* Fixed count of votes cast

* Misc fixes

* changed perferred to preferred lol

* fix count reporting

* Limited poll title character length to 250 (#115)

* Limited poll title character length to 250

* Added backend validation for poll title length

---------

Co-authored-by: Joseph Rosso <jdr1652@rit.edu>

* fix: revert go version stuff

* Fix empty voter in list and also moved documentation (#119)

* feat: update running env stuff

* fix: empty username in the eligible voters

* feat: add ability hide votes if you cannot vote (#121)

* feat: add ability hide votes if you cannot vote

* fix: better for loop

* fix: formatting

---------

Co-authored-by: pikachu0542 <112343747+pikachu0542@users.noreply.github.com>
Co-authored-by: aln730 <arnavgawas707@gmail.com>
Co-authored-by: FlyingCowMaster <flyingcowmaster@gmail.com>
Co-authored-by: Joseph Rosso <jdr1652@rit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants