Skip to content

Draft MEDUI-DEC-007: rendered-check profiles and evidence identity (Proposed) - #25

Merged
AM-L merged 2 commits into
mainfrom
design/dec-007-rendered-check-profiles
Sep 7, 2026
Merged

AM-L merged 2 commits into
mainfrom
design/dec-007-rendered-check-profiles

Conversation

@ambroise-leclerc

Copy link
Copy Markdown
Contributor

Drafts a decision record for #15. Status: Proposed — not an accepted contract change, no allocated identifiers, no schema change.

Distils the issue: the two consumers implement non-interchangeable rendered checks (measured-extent equality vs expanded-region containment; bounded-rounding tint composition vs exact SHA-256; missing baseline pass vs fail) under one MEDUI-DEC-004 golden-selection rule, and no case can catch the divergence.

MEDUI-DEC-007 records the direction — separate versioned rendered-observation profiles with immutable IDs; explicit check families; a derived report identity; an independently-derived obligation set so silence can't pass — and the questions a maintainer must settle before adoption.

validate.py's contiguity check already accepts DEC-007.

Validation: python3 tools/validate.py → OK.

Stacked on #24. Independent of the language-diagnostic PRs; can be reviewed on its own timeline.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new decision text and index introduce small but concrete documentation inconsistencies/ambiguities that should be corrected for accuracy and clarity before merging.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a new proposed decision record (MEDUI-DEC-007) to document the direction for separating rendered-check behavior into versioned profiles with stable identities, and indexes it alongside existing decisions.

Changes:

  • Add MEDUI-DEC-007 (Status: Proposed) describing rendered-check profile/versioning direction and open maintainer questions.
  • Link the new decision from decisions/README.md.
File summaries
File Description
decisions/README.md Adds MEDUI-DEC-007 to the shared decisions index.
decisions/MEDUI-DEC-007-rendered-check-profiles.md Introduces the proposed decision text for rendered-check profiles and evidence identity direction.
Review details

Suppressed comments (1)

decisions/MEDUI-DEC-007-rendered-check-profiles.md:22

  • The document alternates between "Rendered-check profiles" (title) and "rendered-observation profiles" (Direction §1). Using two terms for the same concept is ambiguous; consider picking one term and using it consistently throughout the record.
1. Keep golden selection in the language contract. Define **rendered-observation profiles**
   separately, each with an immutable ID and version, so a report names which check it ran.
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +6 to +8
MduX and TrustSC verifiers. This record states a direction and the questions a maintainer must
settle; it does not change an accepted contract, and nothing here is an allocated `MEDUI-`
identifier until this record is Accepted.
Comment thread decisions/README.md Outdated
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from 56c2965 to 2a5b43d Compare September 7, 2026 07:21
@ambroise-leclerc
ambroise-leclerc force-pushed the design/dec-007-rendered-check-profiles branch from 2a5b43d to a814c61 Compare September 7, 2026 07:27
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from a814c61 to 9641b03 Compare September 7, 2026 07:32
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from 9641b03 to b56d654 Compare September 7, 2026 07:36
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from b56d654 to 48eb072 Compare September 7, 2026 07:38
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from 48eb072 to 3558ebe Compare September 7, 2026 07:41
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from 3558ebe to 4284a27 Compare September 7, 2026 07:46
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from 4284a27 to bcf8fc7 Compare September 7, 2026 08:00
Base automatically changed from release/0.2.0-candidate to main September 7, 2026 08:05
…roposed)

Distils MedUI #15. The two consumers implement non-interchangeable rendered
checks under one MEDUI-DEC-004 golden-selection rule, and no case can catch the
divergence. Records the direction - separate versioned rendered-observation
profiles, explicit check families, a derived report identity, an
independently-derived obligation set - and the questions a maintainer must
settle before adoption. No allocated identifiers, no schema change; Status is
Proposed.
@AM-L
AM-L force-pushed the design/dec-007-rendered-check-profiles branch from bcf8fc7 to e3cc8aa Compare September 7, 2026 08:05
Follow-up to review on PR #25:
- say the record allocates no *new* MEDUI- identifiers until Accepted (it does
  carry its own DEC id)
- use "rendered-check profiles" throughout, matching the title, not a second
  term
- drop the lone status suffix from the decisions index; status lives in the
  record, as with the other entries
@ambroise-leclerc

Copy link
Copy Markdown
Contributor Author

Addressed in c946f01:

  • The intro now says the record allocates no new MEDUI- identifiers (profile names, check IDs, codes) until Accepted — it does carry its own MEDUI-DEC-007 id.
  • "rendered-observation profiles" → "rendered-check profiles" in Direction §1, matching the title; that term is now used consistently.
  • Dropped the lone — Proposed suffix from decisions/README.md; the index stays a plain list and status lives in the record (as with DEC-006 when it was Proposed). I'll do the same for DEC-008 in Draft MEDUI-DEC-008: optional interaction and presentation profiles (Proposed) #26.

@AM-L
AM-L merged commit 6a2b8a1 into main Sep 7, 2026
2 checks passed
@AM-L
AM-L deleted the design/dec-007-rendered-check-profiles branch September 7, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants