Repository navigation
Draft MEDUI-DEC-007: rendered-check profiles and evidence identity (Proposed) - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new decision text and index introduce small but concrete documentation inconsistencies/ambiguities that should be corrected for accuracy and clarity before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new proposed decision record (MEDUI-DEC-007) to document the direction for separating rendered-check behavior into versioned profiles with stable identities, and indexes it alongside existing decisions.
Changes:
- Add
MEDUI-DEC-007(Status: Proposed) describing rendered-check profile/versioning direction and open maintainer questions. - Link the new decision from
decisions/README.md.
File summaries
| File | Description |
|---|---|
| decisions/README.md | Adds MEDUI-DEC-007 to the shared decisions index. |
| decisions/MEDUI-DEC-007-rendered-check-profiles.md | Introduces the proposed decision text for rendered-check profiles and evidence identity direction. |
Review details
Suppressed comments (1)
decisions/MEDUI-DEC-007-rendered-check-profiles.md:22
- The document alternates between "Rendered-check profiles" (title) and "rendered-observation profiles" (Direction §1). Using two terms for the same concept is ambiguous; consider picking one term and using it consistently throughout the record.
1. Keep golden selection in the language contract. Define **rendered-observation profiles**
separately, each with an immutable ID and version, so a report names which check it ran.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+6
to
+8
| MduX and TrustSC verifiers. This record states a direction and the questions a maintainer must | ||
| settle; it does not change an accepted contract, and nothing here is an allocated `MEDUI-` | ||
| identifier until this record is Accepted. |
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 07:21
56c2965 to
2a5b43d
Compare
ambroise-leclerc
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 07:27
2a5b43d to
a814c61
Compare
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 07:32
a814c61 to
9641b03
Compare
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 07:36
9641b03 to
b56d654
Compare
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 07:38
b56d654 to
48eb072
Compare
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 07:41
48eb072 to
3558ebe
Compare
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 07:46
3558ebe to
4284a27
Compare
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 08:00
4284a27 to
bcf8fc7
Compare
…roposed) Distils MedUI #15. The two consumers implement non-interchangeable rendered checks under one MEDUI-DEC-004 golden-selection rule, and no case can catch the divergence. Records the direction - separate versioned rendered-observation profiles, explicit check families, a derived report identity, an independently-derived obligation set - and the questions a maintainer must settle before adoption. No allocated identifiers, no schema change; Status is Proposed.
AM-L
force-pushed
the
design/dec-007-rendered-check-profiles
branch
from
September 7, 2026 08:05
bcf8fc7 to
e3cc8aa
Compare
Follow-up to review on PR #25: - say the record allocates no *new* MEDUI- identifiers until Accepted (it does carry its own DEC id) - use "rendered-check profiles" throughout, matching the title, not a second term - drop the lone status suffix from the decisions index; status lives in the record, as with the other entries
Contributor
Author
|
Addressed in
|
AM-L
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drafts a decision record for #15. Status: Proposed — not an accepted contract change, no allocated identifiers, no schema change.
Distils the issue: the two consumers implement non-interchangeable rendered checks (measured-extent equality vs expanded-region containment; bounded-rounding tint composition vs exact
SHA-256; missing baseline pass vs fail) under oneMEDUI-DEC-004golden-selection rule, and no case can catch the divergence.MEDUI-DEC-007records the direction — separate versioned rendered-observation profiles with immutable IDs; explicit check families; a derived report identity; an independently-derived obligation set so silence can't pass — and the questions a maintainer must settle before adoption.validate.py's contiguity check already acceptsDEC-007.Validation:
python3 tools/validate.py→ OK.Stacked on #24. Independent of the language-diagnostic PRs; can be reviewed on its own timeline.