Repository navigation
Add a dark-theme logo variant to the README - #2
Merged
Merged
Conversation
The logo sat on a light plate, which shows as a pale rectangle on GitHub's dark theme. assets/logo-dark.png is the same artwork with the plate removed and the dark ink set to the brand's dark-theme ink; the README picks it with a <picture> element. assets/logo.png is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
assets/logo-dark.png(new): the existing logo with its light plate removed and the dark navy ink (wordmark, tagline, bulb base) set to the brand's dark-theme ink#F1F5F9. Same pixel size asassets/logo.png; the cloud and rays keep their colours.README.md: the logo<img>is wrapped in a<picture>element so GitHub's dark theme loads the dark variant. The original<img src="assets/logo.png" ...>tag is kept verbatim as the fallback, so the package contract's required strings are unchanged.Why
On GitHub's dark theme the logo rendered as a pale rectangle.
assets/logo.pngitself is not modified.Verified
python scripts/validate_package.py: passedpython -m unittest discover -s tests -p "test_package_*.py": passed#0d1117background and looked at before this PR was opened.Not verified
assets/logo-dark.pngwith an official dark logo if one exists.🤖 Generated with Claude Code