Repository navigation
Perl - CPAN Always Registered as Required Command - #2314
Merged
aaronpowell merged 1 commit intoNov 2, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 2314Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 2314" |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change to installer-specific command validation.
No open issues 🎉
What changed in this PR
Fixes #2313 by moving CPAN availability checks from all Perl applications to installers that actually invoke it, preserving warning-only validation.
Changes:
- Validate each installer’s selected command, including its resolved perlbrew path.
- Add regression coverage for runtime-only resources, package-manager selection, validation timing, and publish mode.
- Document when installer commands are checked and how missing-command warnings behave.
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.Perl.Tests/WithPerlbrewExtensionTests.cs | Updates perlbrew expectations to exclude unconditional CPAN checks. |
| tests/CommunityToolkit.Aspire.Hosting.Perl.Tests/ValidationMessagingTests.cs | Tests resolved installer paths and pre-start warning notifications. |
| tests/CommunityToolkit.Aspire.Hosting.Perl.Tests/RegistrationAndCommandTests.cs | Covers runtime-only resources, installer selection, and configuration order. |
| tests/CommunityToolkit.Aspire.Hosting.Perl.Tests/PublishModeWiringTests.cs | Verifies publish-mode resources do not require CPAN. |
| src/CommunityToolkit.Aspire.Hosting.Perl/README.md | Explains installer-specific checks and warning-only behavior. |
| src/CommunityToolkit.Aspire.Hosting.Perl/PerlAppResourceBuilderExtensions.PackageManager.cs | Registers the resolved installer command with its installation help link. |
| src/CommunityToolkit.Aspire.Hosting.Perl/PerlAppResourceBuilderExtensions.cs | Removes unconditional CPAN registration from Perl applications. |
Review effort: Balanced
Omnideth
force-pushed
the
perl-cpan-always-required
branch
from
October 31, 2026 03:26
84540a3 to
1fab098
Compare
aaronpowell
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2313
Check cpan availability only for installers configured to invoke it. Do not warn about
missing cpan for runtime-only resources or installers using cpanm or Carton.
Preserve the existing warning-only validation behavior.
PR Checklist