Skip to content

Fix progress text metadata negotiation#13386

Open
rattus128 wants to merge 1 commit intoComfy-Org:masterfrom
rattus128:prs/progress-text-meta
Open

Fix progress text metadata negotiation#13386
rattus128 wants to merge 1 commit intoComfy-Org:masterfrom
rattus128:prs/progress-text-meta

Conversation

@rattus128
Copy link
Copy Markdown
Contributor

The preview of Get Image Size particulars broke due to FE protocol updates.

Example Test Conditions:

image

Linux, firefox
Load Image -> Get Image Size -> Preview as Text

Before:

image

After:

image

@rattus128 rattus128 changed the title Prs/progress text meta Fix progress text metadata negotiation Apr 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0dc2e84-2348-42e2-9a10-acf4d235dfe4

📥 Commits

Reviewing files that changed from the base of the PR and between acd7185 and 9ff4b7a.

📒 Files selected for processing (2)
  • comfy_api/feature_flags.py
  • server.py

📝 Walkthrough

Walkthrough

This pull request introduces a new server feature flag supports_progress_text_metadata and modifies the send_progress_text function accordingly. The feature flag is added to SERVER_FEATURE_FLAGS as a default-enabled capability. When enabled, send_progress_text conditionally prepends metadata to progress text messages: a 4-byte length header followed by the current executing prompt ID encoded as UTF-8. The existing node ID and text payload follow this optional header. Additionally, the function now determines the target socket ID from either the provided sid parameter or defaults to self.client_id when enqueueing binary event messages.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix progress text metadata negotiation' directly aligns with the PR's main objective of addressing progress text metadata negotiation between server and client.
Description check ✅ Passed The description is related to the changeset, explaining a bug fix for the preview functionality via protocol updates and providing test conditions with before/after screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant