Skip to content

Ln redshift models - #149

Merged
ColmTalbot merged 3 commits into
ln-smoothed-modelsfrom
ln-redshift-models
Oct 23, 2026
Merged

ColmTalbot merged 3 commits into
ln-smoothed-modelsfrom
ln-redshift-models

Conversation

@ColmTalbot

Copy link
Copy Markdown
Owner

No description provided.

ColmTalbot and others added 2 commits October 23, 2026 13:44
\Lambda in the non-raw docstring is an invalid escape sequence, which
raises a SyntaxWarning when the module is compiled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
_Redshift gains ln_prob, ln_differential_spacetime_volume and
ln_psi_of_z, which defaults to the log of psi_of_z so subclasses keep
working; PowerLawRedshift and MadauDickinsonRedshift implement
ln_psi_of_z with log1p and logaddexp. The normalization is unchanged.
CosmoModel uses these through hyperpe.Model.

With this, every model in gwpopulation.models provides its log
density, and the models documentation says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ColmTalbot
ColmTalbot added this pull request to stack #147 October 23, 2026 18:04
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.61%. Comparing base (c8f2e74) to head (bebb3fc).

Files with missing lines Patch % Lines
gwpopulation/models/redshift.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           ln-smoothed-models     #149      +/-   ##
======================================================
- Coverage               95.61%   95.61%   -0.00%     
======================================================
  Files                      14       14              
  Lines                    1230     1252      +22     
======================================================
+ Hits                     1176     1197      +21     
- Misses                     54       55       +1     
Flag Coverage Δ
python3.10 ?
python3.11 95.61% <95.45%> (-<0.01%) ⬇️
python3.12 95.61% <95.45%> (-<0.01%) ⬇️
python3.13 95.61% <95.45%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Require Python >= 3.11 and stop testing 3.10 in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ColmTalbot
ColmTalbot merged commit b8ecae1 into main Oct 23, 2026
8 checks passed
@ColmTalbot
ColmTalbot deleted the ln-redshift-models branch October 23, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant