Solves shortcut overlap in Calc > Page Layout#15241
Merged
caolanm merged 1 commit intoCollaboraOnline:distro/collabora/co-25.04from Mar 26, 2026
Merged
Conversation
Contributor
|
I attempted to add a test to find all of these with ef0d26e I wonder why that didn't find this? |
caolanm
approved these changes
Mar 26, 2026
Contributor
caolanm
left a comment
caolanm
left a comment
There was a problem hiding this comment.
Aha, I see why it didn't fire, this fix is good.
caolanm
merged commit 5660092
into
CollaboraOnline:distro/collabora/co-25.04
9 checks passed
Signed-off-by: Raul-Ionut Nastasie <raul-ionut.nastasie@collabora.com> Change-Id: Ieab04d0093a619dad415aafbdcdfb71fcb955ce0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ieab04d0093a619dad415aafbdcdfb71fcb955ce0
Summary
Changed Print Range shortcut to avoid overlap
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay