cool#15195 document compare: fix bad horizontal position of comments#15234
Merged
cool#15195 document compare: fix bad horizontal position of comments#15234
Conversation
Open the Writer bugdoc which has a comment, switch to doc compare mode, the comment is between the "old first" and "new first" pages (which are next to each other horizontally), while the expectation is that the comment is on the right of the document content, so should be on the right of the "new first" page. It seems ViewLayoutMultiPage already has some code for this and CommentListSection knows how to use that. Fix this by making that mechanism more general: also implement a getTotalSideSpace() in ViewLayoutCompareChanges, then improve CommentListSection to work with "multi-column layouts" (multi-page view, doc compare view), at a number of locations where previously it only considered the multi-page view. Test that comments are now over the right edge of the "new" pages. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I746fe21d952b6d4da849878c7c3c31a672f1f1a0
Contributor
Author
|
@caolanm could you please review this? Thanks. Second half of this doc compare vs comments story. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open the Writer bugdoc which has a comment, switch to doc compare mode,
the comment is between the "old first" and "new first" pages (which are
next to each other horizontally), while the expectation is that the
comment is on the right of the document content, so should be on the
right of the "new first" page.
It seems ViewLayoutMultiPage already has some code for this and
CommentListSection knows how to use that.
Fix this by making that mechanism more general: also implement a
getTotalSideSpace() in ViewLayoutCompareChanges, then improve
CommentListSection to work with "multi-column layouts" (multi-page view,
doc compare view), at a number of locations where previously it only
considered the multi-page view.
Test that comments are now over the right edge of the "new" pages.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: I746fe21d952b6d4da849878c7c3c31a672f1f1a0