Private/caolan/treeview focus and selection25#15182
Merged
eszkadev merged 4 commits intodistro/collabora/co-25.04from Mar 26, 2026
Merged
Private/caolan/treeview focus and selection25#15182eszkadev merged 4 commits intodistro/collabora/co-25.04from
eszkadev merged 4 commits intodistro/collabora/co-25.04from
Conversation
caolanm
force-pushed
the
private/caolan/treeview_focus_and_selection25
branch
2 times, most recently
from
e083f96 to
5de63bd
Compare
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I28ad5af87f9f6bbf7f738f1a4bda7310cd445134
Treeview rows had no id attribute. When pressing Enter on a treeview entry, core triggers _updateWidgetImpl. That method saves document.activeElement.id, rebuilds the widget, then tries to restore focus by finding an element with that the old id. Since the button had no id the fallback of sending focus to the document body happens. Use the same fix and pattern as: commit 3f985cb Date: Tue Jun 17 13:23:38 2025 +0530 iconview: added support for keyboard navigation after click Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ie37a93dc52d41668169a8c03bcae23c82ad9c710
it goes from the dialog to the document. This can be seen in the chapter/heading dialog in writer. Open the dialog, press twice to ensure the focus can be seen in the treeview, press return, the focus disappears and up/down no longer had an effect. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Iede45ff2bdd3ebdd46776ba48ee3ca009e3023a0
I don't care if the dialog closes or stays open, but if it stays open then the focus should stay in the dialog. Pressing enter poses a problem with chrome during cypress tests with CDP where the form submission default isn't blocked as it is normally. So added a bodge around for that so the issue can be property tested. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I5e241ea91f7467643b4a9c63eb1ea045df8527fa
caolanm
force-pushed
the
private/caolan/treeview_focus_and_selection25
branch
from
5de63bd to
b64755d
Compare
Contributor
Author
|
I'd like to backport this to 25.04, the original review was #15123 |
eszkadev
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay