Active-state tooltip for Clone Formatting toolitem#15174
Merged
pedropintosilva merged 1 commit intomainfrom Mar 30, 2026
Merged
Active-state tooltip for Clone Formatting toolitem#15174pedropintosilva merged 1 commit intomainfrom
pedropintosilva merged 1 commit intomainfrom
Conversation
6ac9693 to
f46deee
Compare
f46deee to
418627f
Compare
418627f to
5efb770
Compare
pedropintosilva
requested changes
Mar 25, 2026
| 'text': _UNO('.uno:FormatPaintbrush'), | ||
| 'tooltip': _('Clone Formatting (double click to keep active)'), | ||
| 'activeTooltip': _('Clone Formatting is active (click again or press Escape to exit)'), | ||
| 'activeDoubleClickTooltip': _('Clone Formatting is active (press Escape to exit)'), |
Contributor
There was a problem hiding this comment.
why this one doesn't mention click. shouldn't be the same as the pprevious. Also please use Esc instead of Escape is shorter and easier on translations.
Contributor
|
Thanks Darshan! Unfortunately I think some things need to go:
Let's keep the tooltips but only appear with normal mouseover. Additionally , we could think if we could add a new status bar status to signal whenever the Clone formatting is active, but better to wait for user feedback before doing that change. |
7194d9c to
9d711d0
Compare
- this patch will add tooltip option for active element - it sets the tooltip if option is enable and then set back to normal on toggle back to normal state - When Clone Formatting is active, swap the tooltip to inform the user how to exit (click again or press Esc). Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I30dea9dfd59594f1ea81477afdffa031b15103a5
9d711d0 to
738aebf
Compare
pedropintosilva
approved these changes
Mar 30, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolitem definitions can now declare
activeTooltipandactiveDoubleClickTooltipproperties to show context-sensitive tooltips when their command state changes. On double-click activation, the button also plays a shake animation to draw the user's attention.The tooltip and animation logic lives in
UIManager.showAttention(), replacing the inline implementation that was previously duplicated inMap.Keyboard.jsfor the view-mode dropdown.In
JSDialogBuilder._toolitemHandler, the existingupdateFunctionnow tracks activation via_wasActiveTooltipand_activatedByDoubleClickon the DOM element, so tooltips only appear on real user interactions and not during initial document load.Applied to Clone Formatting as the first consumer:
Screencast.from.2026-03-23.23-28-43.webm
Change-Id: I30dea9dfd59594f1ea81477afdffa031b15103a5
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay