Feat vqa remote#173
Draft
MoHermes wants to merge 53 commits into
Draft
Conversation
…/mpqp into feat-vqa-remote
Comment on lines
+2132
to
+2140
| def transpiled_for_device(self, device: AvailableDevice): | ||
| if device not in self.transpiled_circuit: | ||
| self.transpiled_circuit[device] = ( | ||
| self.to_other_device( # pyright: ignore[reportCallIssue] | ||
| device # pyright: ignore[reportArgumentType] | ||
| ) | ||
| ) | ||
| return self.transpiled_circuit[device] | ||
|
|
Contributor
There was a problem hiding this comment.
For some providers, we would call to_other_device for each device , because MPQP translation and transpilation is device specific (like IBM), but for AWS/QLM for instance, we only need to_other_language (which is handled by to_other_device if I remember well), but then would need a different indexing of the dictionnary, otherwise we would export the mpqp circuit many times if we change the AWSDevice for instance (while we could have avoided).
� Conflicts: � mpqp/core/instruction/measurement/expectation_value.py � mpqp/execution/providers/atos.py � mpqp/execution/providers/aws.py � mpqp/execution/providers/google.py � mpqp/execution/providers/ibm.py � mpqp/execution/runner.py � mpqp/execution/vqa/vqa.py
…dling - Introduced VQAModule for managing multiple circuits and optimization processes. - Updated optimizer functions to utilize OptimizerData for better parameter management. - Refactored minimize function to streamline optimization logic and support new evaluation methods. - Improved handling of ExpectationMeasure and observable pre-transpilation in QCircuit. - Added tests for VQAModule across different providers to ensure functionality. - Adjusted parameter binding logic in QCircuit to enhance flexibility.
… into feat-vqa-remote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.