Upgrade jjwt 0.11.2 → 0.12.6 - #207
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
jjwt-api/jjwt-impl/jjwt-jacksonfrom 0.11.2 (2020) to 0.12.6, the latest release, and migratesDefaultJwtServiceoff the APIs removed/deprecated in 0.12. Token format and signing behavior are unchanged.API migration in
DefaultJwtService:Key construction is the subtle part. The old code built the key as
new SecretKeySpec(secret.getBytes(), SignatureAlgorithm.HS512.getJcaName()), i.e. it always tagged the key asHmacSHA512regardless of the secret's actual length, and relied on 0.11'ssignWith(Key)picking the algorithm purely from key bit length. In 0.12, algorithm lookup for aSecretKeyconsiders the key's JCA name and rejects it if the key is too short for that algorithm — so a sub-512-bit secret taggedHmacSHA512no longer resolves to an algorithm. Replaced withKeys.hmacShaKeyFor(secret.getBytes()), which tags the keyHmacSHA256/384/512according to its actual length, preserving the algorithm 0.11 would have selected for any given secret (the configured 88-char secret still yields HS512).SignatureAlgorithm(deprecated in 0.12) is no longer referenced.Verification
./gradlew clean test— 68 tests, 0 failures (includesDefaultJwtServiceTest, plus the API tests that exercise auth end-to-end)../gradlew spotlessCheck— passes.Note:
spotlessCheckandjacocoTestCoverageVerificationboth fail onmainin this environment (google-java-format needs--add-exportson JDK 17; coverage sits at 0.33 vs the 0.80 rule) — both are pre-existing and unrelated; CI runsclean test -x jacocoTestCoverageVerification.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/24e6605322a84c5ca158b576b5ebd66f
Requested by: @mbatchelor81