Skip to content

Upgrade selenium-java 4.15.0 → 4.46.0 (highest 4.x on Java 11) and unpin it from the Boot 2.6.3 BOM #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade selenium-java 4.15.0 → 4.46.0 (highest 4.x on Java 11) and unpin it from the Boot 2.6.3 BOM #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/java-engineering-excellence/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ ts-java-spring-boot-realworld/
| `io.rest-assured:spring-mock-mvc` (test) | 4.5.1 | 5.4.x |
| `com.diffplug.spotless` | 6.2.1 | 6.25.x |
| `org.flywaydb:flyway-core` | (managed) | 10.x (Boot 3.5 managed) |
| Selenium (test) | 4.15.0 | 4.20.x |
| Selenium (test) | 4.46.0 (`ext['selenium.version']` overrides the Boot BOM's 3.141.59) | 4.46.x |

## General Approach: Java 11 → 21 / Spring Boot 2.x → 3.x Upgrades

Expand Down
6 changes: 5 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ configurations {
}
}

// The Spring Boot 2.6.3 BOM manages org.seleniumhq.selenium at 3.141.59, which would drag
// selenium-java's own modules back to 3.x and split the classpath.
ext['selenium.version'] = '4.46.0'

dependencies {
implementation 'org.springframework.boot:spring-boot-starter-web'
implementation 'org.springframework.boot:spring-boot-starter-validation'
Expand Down Expand Up @@ -82,7 +86,7 @@ dependencies {
testImplementation 'org.mockito:mockito-inline:4.0.0'

// Selenium E2E testing
testImplementation 'org.seleniumhq.selenium:selenium-java:4.15.0'
testImplementation 'org.seleniumhq.selenium:selenium-java:4.46.0'
testImplementation 'io.github.bonigarcia:webdrivermanager:5.6.2'
testImplementation 'org.testng:testng:7.8.0'
testImplementation 'com.aventstack:extentreports:5.1.1'
Expand Down
5 changes: 3 additions & 2 deletions src/test/java/io/spring/selenium/pages/BasePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.spring.selenium.pages;

import java.time.Duration;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.support.PageFactory;
Expand All @@ -11,11 +12,11 @@ public abstract class BasePage {

protected WebDriver driver;
protected WebDriverWait wait;
protected static final long DEFAULT_TIMEOUT_SECONDS = 10;
protected static final Duration DEFAULT_TIMEOUT = Duration.ofSeconds(10);

public BasePage(WebDriver driver) {
this.driver = driver;
this.wait = new WebDriverWait(driver, DEFAULT_TIMEOUT_SECONDS);
this.wait = new WebDriverWait(driver, DEFAULT_TIMEOUT);
PageFactory.initElements(driver, this);
}

Expand Down
Loading