Upgrade webdrivermanager 5.6.2 -> 6.0.1 (highest 6.x runnable on the pinned httpclient5 5.2.1) - #204
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Highest 6.x compatible with the pinned httpclient5 5.2.1; 6.1.0+ requires httpclient5 >= 5.4 (org.apache.hc.client5.http.ssl.TlsSocketStrategy). No source changes: WebDriverManager.chromedriver()/firefoxdriver()/edgedriver().setup() are unchanged in 6.x.
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades WebDriverManager to the highest 6.x release that actually runs on this project's classpath. Java 11 is not the limiting factor — every WDM 6.x jar is compiled to bytecode major 52 (Java 8) — but httpclient5 is: WDM 6.1.0+ calls
org.apache.hc.client5.http.ssl.TlsSocketStrategy, introduced in httpclient5 5.4, and this repo pinshttpclient5:5.2.1(owned by a different session). So the target is 6.0.1, the last 6.x that works against httpclient5 5.2.1.Why not 6.3.4 (latest 6.x)
WebDriverManager.chromedriver().setup()was run on the real resolvedtestRuntimeClasspath(JDK 11) with each candidate jar swapped in:SETUP_OKSETUP_OKSETUP_OKNoClassDefFoundError: org/apache/hc/client5/http/ssl/TlsSocketStrategyGoing higher would require bumping
httpclient5to >= 5.4, which is out of scope for this PR (one artifact family per PR, and httpclient5 is another session's dependency). Note that Spring Boot's dependency-management plugin pins httpclient5 by rule, so WDM 6.3.4's own request forhttpclient5:5.6is silently downgraded to5.2.1— a green build alone would have hidden this; only the runtime smoke test surfaced it.Also verified: 6.0.1 is a stable release published 2025-04-02 (well over 7 days old), no
-M/-RC/-alpha/-beta.BOM /
extoverridesNone needed.
webdrivermanageris not managed by the Spring Boot 2.6.3 BOM, so the literal version inbuild.gradleis authoritative.dependencyInsightevidenceNo conflict resolution downgrade, and only one WDM version on the classpath.
Selenium is unaffected
dependencyInsight --dependency org.seleniumhq.seleniumproduces byte-identical output before and after this change. WDM declaresselenium-javaatprovidedscope, so it contributes nothing to the Gradle runtime graph and drags no Selenium version onto the classpath.For the record, the resolved Selenium graph (unchanged by this PR, listed here so it is not mistaken for a regression) is already split on
main:selenium-java:4.15.0is declared explicitly, while every sub-artifact (selenium-api,selenium-remote-driver,selenium-support, ...) is forced to3.141.59 (selected by rule)by the Spring Boot 2.6.3 BOM's managedselenium.version. That pre-dates this change and belongs to whoever owns the Selenium coordinate.httpclient5also resolves to5.2.1 (selected by rule)both before and after.API migration
No source changes needed. The only usages are in
src/test/java/io/spring/selenium/tests/BaseTest.java:All three static factories and
setup()exist with identical signatures in 6.0.1 (javapon the 6.x jar confirmspublic static synchronized WebDriverManager chromedriver()andpublic synchronized void setup()). Nothing else in the repo referencesio.github.bonigarciaor the literal string5.6.2, so there were no stale docs/CI references to update.compileTestJavacompiles the Selenium sources cleanly:Gate
main(3037fa5)Same test count, zero new failures,
spotlessCheckgreen (spotlessApplyrun before committing). The Selenium E2E suite is a separate TestNGseleniumTesttask excluded fromtest, so it is not part of the gate — it was validated separately by the runtimesetup()smoke test above.Pre-existing on base, not addressed here
jacocoTestCoverageVerificationfails — 0.33 instruction coverage vs. the 0.80 rule inbuild.gradle. Fails identically on untouchedmain; CI runs./gradlew clean test -x jacocoTestCoverageVerification, and this PR excludes it the same way. Threshold not lowered, no tests added to game coverage.selenium-java:4.15.0alongside BOM-forced3.141.59sub-artifacts (see above). Present onmain, unchanged by this PR, and out of scope.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/ab8d8dbe8e2e41fe8f1957054d98bf40
Requested by: @mbatchelor81