Upgrade httpclient5 5.2.1 -> 5.6.1 (pin httpcore5 5.4) - #199
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Upgrade httpclient5 5.2.1 -> 5.6.1 (pin httpcore5 5.4)#199devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the test-scoped Apache HttpClient 5 to the latest stable 5.x (
5.6.1, published 2026-04-14) and pins the companionhttpcore5line so the Spring Boot 2.6.3 BOM stops downgrading it. Build-file change only — no source changes.Why the
extoverridesThe Boot 2.6.3 BOM pins
httpclient5.version=5.1.2/httpcore5.version=5.1.3, and theio.spring.dependency-managementplugin applies those to transitive resolution. Onmainthis already produced a split classpath:httpclient5:5.2.1requestedhttpcore5:5.2, but the BOM rule dragged it back to5.1.3(org.apache.httpcomponents.core5:httpcore5:5.2 -> 5.1.3).5.6.1requireshttpcore5 5.4, so the managed properties are overridden rather than adding new dependency lines;httpclient5.versionis overridden too so transitive requests (Selenium'swebdrivermanagerat5.2.1,docker-java-transport-httpclient5at5.0.3) cannot be managed back down.dependencyInsightevidence (target version actually resolved)./gradlew dependencyInsight --configuration testRuntimeClasspath --dependency org.apache.httpcomponents.client5:httpclient5... --dependency org.apache.httpcomponents.core5All upgrades resolve upward; no conflict-resolution downgrade and no two versions of the family on the classpath.
httpclient5 5.6.1targets Java 8 bytecode, so it is fine on the Java 11 / Boot 2.6.3 ceiling — no Boot 3 / Java 17 requirement was hit.API migration
No source changes needed.
grep -rn "org.apache.hc" src/returns zero matches —httpclient5is present only as a transitive runtime need of the Selenium/webdrivermanager stack, never imported by repo code.compileTestJavais clean.Gate
JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 ./gradlew clean test spotlessCheck -x jacocoTestCoverageVerificationmain@ 3037fa5)spotlessCheckBaseline was re-run first-hand on untouched
mainbefore editing.Pre-existing on base, not addressed here
jacocoTestCoverageVerificationfails onmainat ~0.33 instruction coverage against the 0.80 rule inbuild.gradle. CI excludes it (./gradlew clean test -x jacocoTestCoverageVerification), and this PR excludes it identically. The threshold was not lowered and no tests were added.spotlessJavaimplicit-dependency and deprecation warnings on both base and this branch; unrelated to this change.Out of scope by assignment:
selenium-java,webdrivermanager,testng, and every other dependency inbuild.gradleare untouched.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/31a2a780b4ab41a4bf4dc5a32b842b7e
Requested by: @mbatchelor81