Upgrade jjwt 0.11.2 -> 0.12.6 - #194
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
jjwt-api/jjwt-impl/jjwt-jacksonto 0.12.6 and migratesDefaultJwtServiceto the 0.12 API (the 0.11parserBuilder()/parseClaimsJws()path is gone).Note on the key: the old code hard-coded the JCA name
HmacSHA512on theSecretKeySpec, butsignWith(key)in 0.11 still selected the algorithm purely from key length. In 0.12 a key whose JCA name says HS512 while being shorter than 512 bits no longer resolves to any algorithm, which would break the 480-bit secret used inDefaultJwtServiceTest.Keys.hmacShaKeyForpicks the JCA name from the key length, preserving the previous behavior (HS512 for the 688-bit configuredjwt.secret).Verification:
./gradlew clean test spotlessCheck— 68 tests, 0 failures, Spotless clean.jacocoTestCoverageVerificationstill fails at 0.33 line coverage, which is pre-existing onmain(the repo's test command excludes that task).Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/21599492e24a4fff86cd548540f5e681
Requested by: @mbatchelor81