fix: filter CodeQL false positives in SARIF checker - #122
Merged
Conversation
CodeQL query-filters in config YAML doesn't reliably suppress specific rules from SARIF output. Add a _FALSE_POSITIVE_RULES frozenset to the SARIF checker script to skip known intentional patterns: - py/weak-sensitive-data-hashing: SHA-1 used for feature hashing (the hashing trick) in embedder_deterministic.py, not for security. Code sets usedforsecurity=False.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL query-filters in config YAML doesn't suppress the py/weak-sensitive-data-hashing finding from SARIF output. Add a _FALSE_POSITIVE_RULES frozenset to check_codeql_sarif.py to skip known intentional patterns (SHA-1 feature hashing with usedforsecurity=False).