Skip to content

Add treeshaked code back #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CGNonofr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add treeshaked code back #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba9fdb
fix: mark other constructors as having side effects
Mar 17, 2026
37f2f90
fix: missing usage of mainWindow
Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion rollup/tools/vscode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,22 @@ const PURE_FUNCTIONS = new Set([
])

const EXTENSIONS = ['', '.ts', '.js']
const SIDE_EFFECT_CONSTRUCTORS = new Set(['DomListener'])
const SIDE_EFFECT_CONSTRUCTORS = new Set([
'DomListener',
'TimeoutTimer',
'AbstractIdleValue',
'WindowIdleValue',
'GlobalIdleValue',
'AsyncIterableObject',
'AsyncIterableSource',
'AsyncIterableProducer',
'CancelableAsyncIterableProducer',
'ActiveElementTracker',
'WindowIdleValue',
'TimeoutThrottledDomListener',
'FocusTracker',
'DragAndDropObserver'
])

const PURE_OR_TO_REMOVE_FUNCTIONS = new Set([...PURE_FUNCTIONS])

Expand Down
16 changes: 15 additions & 1 deletion vscode-patches/0067-feat-support-loading-VSCode-in-an-iframe.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Subject: [PATCH] feat: support loading VSCode in an iframe
.../inlineEditsViews/debugVisualization.ts | 5 ++-
.../browser/view/inlineEdits/utils/utils.ts | 10 ++---
.../clipboard/browser/clipboardService.ts | 2 +-
src/vs/platform/hover/browser/hoverService.ts | 2 +-
.../remote/browser/browserSocketFactory.ts | 2 +-
.../workbench/browser/parts/dialogs/dialog.ts | 3 +-
src/vs/workbench/browser/window.ts | 25 +++++++----
Expand All @@ -45,7 +46,7 @@ Subject: [PATCH] feat: support loading VSCode in an iframe
.../request/browser/requestService.ts | 3 +-
.../electron-browser/requestService.ts | 3 +-
.../services/timer/browser/timerService.ts | 5 ++-
41 files changed, 128 insertions(+), 124 deletions(-)
42 files changed, 129 insertions(+), 125 deletions(-)

diff --git a/src/vs/base/browser/browser.ts b/src/vs/base/browser/browser.ts
index 9da1be69d7c..08d8860ea36 100644
Expand Down Expand Up @@ -620,6 +621,19 @@ index 358aa682cda..b41a1f1346b 100644
const clipboardItem = clipboardItems[0];

const supportedImageTypes = ['image/png', 'image/jpeg', 'image/gif', 'image/tiff', 'image/bmp'];
diff --git a/src/vs/platform/hover/browser/hoverService.ts b/src/vs/platform/hover/browser/hoverService.ts
index cfb53e2e686..f23776d2d53 100644
--- a/src/vs/platform/hover/browser/hoverService.ts
+++ b/src/vs/platform/hover/browser/hoverService.ts
@@ -364,7 +364,7 @@ export class HoverService extends Disposable implements IHoverService {
}

if ('IntersectionObserver' in mainWindow) {
- const observer = new IntersectionObserver(e => this._intersectionChange(e, hover), { threshold: 0 });
+ const observer = new mainWindow.IntersectionObserver(e => this._intersectionChange(e, hover), { threshold: 0 });
const firstTargetElement = 'targetElements' in options.target ? options.target.targetElements[0] : options.target;
observer.observe(firstTargetElement);
hoverDisposables.add(toDisposable(() => observer.disconnect()));
diff --git a/src/vs/platform/remote/browser/browserSocketFactory.ts b/src/vs/platform/remote/browser/browserSocketFactory.ts
index eafeef861a1..8859ceacf87 100644
--- a/src/vs/platform/remote/browser/browserSocketFactory.ts
Expand Down
Loading