Skip to content

Make custom editor service instantiation eager #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGNonofr merged 1 commit into from
Mar 16, 2026
+5 −1
Merged

Make custom editor service instantiation eager #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/service-override/viewCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@ function getServiceOverride(_webviewIframeAlternateDomains?: string): IEditorOve
true
),
[IHistoryService.toString()]: new SyncDescriptor(HistoryService, [], false),
[ICustomEditorService.toString()]: new SyncDescriptor(CustomEditorService, [], true),
[ICustomEditorService.toString()]: new SyncDescriptor(
CustomEditorService,
[],
/** CustomEditorService registers the contribution point, so its instantiation can't be delayed */ false
),
[IWebviewService.toString()]: new SyncDescriptor(WebviewService, [], true),
[IWebviewViewService.toString()]: new SyncDescriptor(WebviewViewService, [], true),
[IWebviewWorkbenchService.toString()]: new SyncDescriptor(WebviewEditorService, [], true),
Expand Down
Loading