Skip to content

[DEMO] add chat examples#778

Merged
onora-hbl merged 7 commits intomainfrom
ohr/chat-in-demo
Mar 17, 2026
Merged

[DEMO] add chat examples#778
onora-hbl merged 7 commits intomainfrom
ohr/chat-in-demo

Conversation

@onora-hbl
Copy link
Contributor

No description provided.

@onora-hbl onora-hbl requested a review from CGNonofr March 13, 2026 11:16
@onora-hbl onora-hbl force-pushed the ohr/chat-in-demo branch 2 times, most recently from 14dce43 to efde4e9 Compare March 13, 2026 13:04
@onora-hbl onora-hbl self-assigned this Mar 13, 2026
@onora-hbl
Copy link
Contributor Author

onora-hbl commented Mar 13, 2026

@CGNonofr do you have an idea why I have errors in the registerExtension? It looks like the type of IExtensionManifest is not correct

@CGNonofr
Copy link
Contributor

@CGNonofr do you have an idea why I have errors in the registerExtension? It looks like the type of IExtensionManifest is not correct

It is! It's incomplete unfortunately, I've made an attempt to make it more exhaustive but it's still missing some stuff

either you cast it and ignore the error, or better: you amend the fix: improve extension contribution types commit

@onora-hbl
Copy link
Contributor Author

@CGNonofr do you have an idea why I have errors in the registerExtension? It looks like the type of IExtensionManifest is not correct

It is! It's incomplete unfortunately, I've made an attempt to make it more exhaustive but it's still missing some stuff

either you cast it and ignore the error, or better: you amend the fix: improve extension contribution types commit

Thanks, I added 3247872

@CGNonofr
Copy link
Contributor

@CGNonofr do you have an idea why I have errors in the registerExtension? It looks like the type of IExtensionManifest is not correct

It is! It's incomplete unfortunately, I've made an attempt to make it more exhaustive but it's still missing some stuff
either you cast it and ignore the error, or better: you amend the fix: improve extension contribution types commit

Thanks, I added 3247872

perfect! 👍

@onora-hbl
Copy link
Contributor Author

@CGNonofr I amended to add the missing modes key in participant definition

@onora-hbl onora-hbl merged commit 815ed88 into main Mar 17, 2026
2 checks passed
@onora-hbl onora-hbl deleted the ohr/chat-in-demo branch March 17, 2026 10:17
@github-actions
Copy link

🎉 This PR is included in version 28.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants