Skip to content

fix(layout): correct mainContainerDimension#776

Merged
CGNonofr merged 1 commit intoCodinGame:mainfrom
prclin:patch-1
Mar 10, 2026
Merged

fix(layout): correct mainContainerDimension#776
CGNonofr merged 1 commit intoCodinGame:mainfrom
prclin:patch-1

Conversation

@prclin
Copy link
Contributor

@prclin prclin commented Mar 10, 2026

get mainContainerDimension(): dom.IDimension {
    return this._mainContainerDimension
  }

this always return the document.body dimension.
when container is not body, the quick input widget will offset;

so changes below

layout(): void {
  //this._mainContainerDimension = dom.getClientArea(window.document.body)
    this._mainContainerDimension = dom.getClientArea(this.mainContainer)

    this._onDidLayout.fire(this._mainContainerDimension)
  }

@CGNonofr
Copy link
Contributor

Thanks!

@CGNonofr CGNonofr self-requested a review March 10, 2026 09:32
@CGNonofr CGNonofr merged commit f7c8650 into CodinGame:main Mar 10, 2026
2 checks passed
@github-actions
Copy link

🎉 This PR is included in version 28.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants