Skip to content

Jarvis+newengine.py#6

Open
kushag09 wants to merge 1 commit intoCodexTraveler:masterfrom
kushag09:master
Open

Jarvis+newengine.py#6
kushag09 wants to merge 1 commit intoCodexTraveler:masterfrom
kushag09:master

Conversation

@kushag09
Copy link
Copy Markdown

@kushag09 kushag09 commented Oct 1, 2020

No description provided.

Copy link
Copy Markdown

@ri5h ri5h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Jarvis+newengine.py



speak('What is the subject? ')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
speak('What is the subject? ')
speak('What is the subject?')

Comment thread Jarvis+newengine.py
speak('What is the message?')
msg = myCommand()

content = 'Subject: {}\n\n{}'.format(subject, msg)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an overkill but in future we should ask the user if he wants to verify the contents, and repeat it if he says yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants