feat(maintainer): add CSV export for PR queue (#87)#151
feat(maintainer): add CSV export for PR queue (#87)#151Sujini-kudupudi wants to merge 3 commits into
Conversation
|
@Sujini-kudupudi is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Please see this #67 (comment) |
|
@Sujini-kudupudi please solve the conflicts. Thanks |
Siddhartha-singh01
left a comment
There was a problem hiding this comment.
Hi @Sujini-kudupudi the CSV-export feature itself looks fine, but the conflict
resolution in your last two merge commits corrupted maintainer.ts. Specifically,
your new exportPrQueueCsv function is never closed before main's
getRepoHealthOverview starts both function bodies got interleaved into one.
You can see it at lines 604-612:
export async function exportPrQueueCsv(
installationId: number,
filters?: Partial<QueueFilters>,
): Promise<Result<string>> {
const sb = getServerSupabase();
if (!sb) return err('not_configured', 'auth not configured');
const service = getServiceSupabase();
if (!service) return err('not_configured', 'service role missing');
export async function getRepoHealthOverview(): Promise<Result<RepoHealthRow[]>> {There's no closing } between line 611 and 612. The file doesn't parse — npm run typecheck will fail, and CI will go red shortly. There are even two rateLimit
calls (one with namespace: 'maint:csv', one with namespace: 'maintainer') in
the merged body, which confirms the two functions got smashed together.
The cleanest fix is to reset and redo the merge:
git reset --hard ec92b80 # back to your original feature commit
git fetch upstream main
git rebase upstream/main # resolve conflicts carefully this time
git push --force-with-leaseWhen you resolve the conflicts, make sure exportPrQueueCsv is fully closed (the
auth/rate-limit/listMaintainerRepos/validateFilters/CSV-build logic + its return ok(csv) and }) BEFORE getRepoHealthOverview starts.
Critical step: run npm run typecheck locally before pushing that catches
this immediately. If typecheck is green, the merge is sound.
I'll re-review as soon as CI is green. The feature is welcome just needs a clean
merge to land.
Summary
Adds a one-click CSV export feature for maintainers to download a snapshot of the PR queue matching their active filters. This enables maintainers to easily share queue states with co-maintainers and load them into spreadsheets for planning.
Type of Change
Related Issue
Closes #87
What was changed?
exportPrQueueCsvserver action insrc/app/actions/maintainer.tsto fetch filter-matching PRs and format them as CSV (omitting the standard 25-item page limit).ExportCsvButtonclient component insrc/app/(app)/maintainer/export-csv-button.tsxto trigger the action and handle the secure browser Blob download.github_updated_at.Screenshots
(If you'd like, you can drag and drop a quick screenshot of the new Export CSV button here before creating the PR!)
Checklist
npm run dev)