Skip to content

Fix NaN handling in pct function in db-health-alerts #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar-vh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NaN handling in pct function in db-health-alerts #1240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions common/src/util/db-health-alerts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,10 @@ export function evaluateStatCoverage(row: StatCoverageRow): StatCoverage {
// may break the alert that does not consult it.
const statementsBlind = statementRows === 0
const activityBlind = activityVisible === 0
const pct = (part: number, whole: number) =>
whole > 0 ? Math.round((part / whole) * 100) : 0
const pct = (part: number, whole: number) => {
if (!Number.isFinite(part) || !Number.isFinite(whole) || whole <= 0) return 0
return Math.round((part / whole) * 100)
}
const summary = row.has_read_all_stats
? `role ${row.role} has pg_read_all_stats: full fleet visibility`
: `role ${row.role} lacks pg_read_all_stats — ${statementsWithText}/${statementRows} ` +
Expand Down
Loading